Enable no_implicit_optional in mypy config #5457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zenmonkeykstop
approved these changes
Aug 20, 2020
There was a problem hiding this comment.
Looks good based on visual review, no other affected code found, and make typelint is passing,
Approved and thanks, @nabla-c0d3 !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready for review
Description of Changes
To help with #4399 , this PR adds
no_implicit_optional = Trueto the mypy config and then fixes the few type errors triggered by this change.This will eventually be the default setting in mypy ( python/mypy#9091 ) and seemed easy enough to add to Securedrop now, before a lot of non-compatible type annotations get added.