Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove test result combination script #5575

Merged
merged 2 commits into from
Oct 15, 2020

Conversation

nebelsprachen
Copy link

Status

Ready for review

Description of Changes

Removes script that is no longer used

Fixes #4746

Changes proposed in this pull request:

Testing

How should the reviewer test this PR?

Deployment

Any special considerations for deployment? Consider both:

  1. Upgrading existing production instances.
  2. New installs.

Checklist

If you made changes to the server application code:

  • Linting (make lint) and tests (make test) pass in the development container

If you made changes to securedrop-admin:

  • Linting and tests (make -C admin test) pass in the admin development container

If you made changes to the system configuration:

If you made non-trivial code changes:

  • I have written a test plan and validated it for this PR

If you made changes to documentation:

  • Doc linting (make docs-lint) passed locally

If you added or updated a code dependency:

Choose one of the following:

  • I have performed a diff review and pasted the contents to the packaging wiki
  • I would like someone else to do the diff review

Copy link
Contributor

@emkll emkll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we also aren't using the script it's invoking, do you think it makes sense to remove that one as well? https://github.com/joaedwar/securedrop/blob/4746_Test-scripts/devops/scripts/combine-junit.py

It seems like we forgot to clean this up when migrating platforms for CI in https://github.com/freedomofpress/securedrop/pull/3909/files

@nebelsprachen
Copy link
Author

@emkll Please review. I removed the suggested file.

Copy link
Contributor

@emkll emkll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @joaedwar !

@emkll emkll merged commit a0b53d3 into freedomofpress:develop Oct 15, 2020
@eloquence eloquence added this to the 1.7.0 milestone Jan 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test result combination scripts can be removed
3 participants