Remove unused confirm_bulk_delete functionality #6261
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready for review
Description of Changes
This page was originally used as a confirmation interstitial when deleting
files or messages, but in 1e64f36 (#2946) it was replaced with a CSS-only
deletion confirmation on the same page, so users would never hit the
separate confirmation page.
Remove the tests that were still calling this endpoint, the HTML template
and code that was checking for the "confirm_delete" action.
I noticed this when investigating a translator comment about the "Permanently Delete Files" text and was unable to figure out how to take a screenshot of it. We probably don't need to get this into 2.2.0, but maybe we can mark these strings as not requiring translation in the meantime.
Testing
Deployment
Any special considerations for deployment? No
Checklist
make lint
) and tests (make test
) pass in the development container