Link citations cannot be disambiguated #5016
Conversation
…ter page and add class for those linked citations
…ter page and add class for those linked citations
…hats-ok-we-can-send-it-to-a-c-page-which-will-list-multiple-options
![semgrep-app[bot]](https://avatars.githubusercontent.com/in/60555?s=60&v=4){kind=small}
| '<span class="citation multiple-matches">' | ||
| f'<a href="{reverse("citation_redirector", args=[citations[0].groups["reporter"], citations[0].groups["volume"], citations[0].groups["page"]])}">', |
There was a problem hiding this comment.
Semgrep identified an issue in your code:
Detected strings that are implicitly concatenated inside a list. Python will implicitly concatenate strings when not explicitly delimited. Was this supposed to be individual elements of the list?
To resolve this comment:
🔧 No guidance has been designated for this issue. Fix according to your organization's approved methods.
💬 Ignore this finding
Leave a nosemgrep comment directly above or at the end of line 72 like so // nosemgrep: python.lang.correctness.common-mistakes.string-concat-in-list.string-concat-in-list
Take care to validate that this is not a true positive finding before ignoring it.
Learn more about ignoring code, files and folders here.
You can view more details about this finding in the Semgrep AppSec Platform.
…hats-ok-we-can-send-it-to-a-c-page-which-will-list-multiple-options
for more information, see https://pre-commit.ci
…hats-ok-we-can-send-it-to-a-c-page-which-will-list-multiple-options
…hats-ok-we-can-send-it-to-a-c-page-which-will-list-multiple-options
…hats-ok-we-can-send-it-to-a-c-page-which-will-list-multiple-options
This PR addresses the issue of linking citations that cannot be disambiguated to /c/reporter/volume/page/ (e.g. "114 F.3d 1182" will be linked to/c/f3d/114/1182/) so the user can figure it out which open.
It uses a similar approach that is being used for NO_MATCH_RESOURCE but setting an impossible citation for the FullCaseCitation object (999999 U.S. 999999) to have a different hash than NO_MATCH_RESOURCE because the object is being used as key for citation resolution dictionary.