Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Polkadot SDK to Stable2407 and Enhance Configurations #773

Merged
merged 34 commits into from
Nov 29, 2024

Conversation

magecnion
Copy link
Contributor

@magecnion magecnion commented Sep 12, 2024

PR Type

Enhancement, Bug fix


Description

  • Upgraded the Polkadot SDK to the stable2407 branch across multiple files, ensuring compatibility with the latest stable features.
  • Added XcmRecorder to various XCM configurations to enhance XCM handling.
  • Simplified and cleaned up configurations and tests, removing unused parameters and functions.
  • Updated dependencies in Cargo.toml to align with the new SDK version.
  • Suppressed deprecated warnings in several modules to maintain code quality.

Changes walkthrough 📝

Relevant files
Enhancement
14 files
laos.rs
Simplify ChainSpec Type Definition                                             

node/src/chain_spec/laos.rs

  • Simplified the ChainSpec type definition.
+1/-2     
eth.rs
Suppress Deprecated Warnings in Eth Module                             

node/src/eth.rs

  • Added #[allow(deprecated)] attribute to suppress warnings.
+2/-0     
service.rs
Suppress Warnings and Remove Unused Parameters                     

node/src/service.rs

  • Added #[allow(deprecated)] attribute to suppress warnings.
  • Removed sync_oracle parameter from functions.
  • +5/-8     
    tests.rs
    Simplify Reset Issuance Function in Tests                               

    pallets/parachain-staking/src/tests.rs

    • Simplified the reset_issuance function.
    +1/-10   
    cumulus_xcmp_queue.rs
    Add New Parameter Types for XCMP Queue                                     

    runtime/laos/src/configs/cumulus_xcmp_queue.rs

  • Added new parameter types for MaxActiveOutboundChannels and
    MaxPageSize.
  • +10/-1   
    treasury.rs
    Clean Up Treasury Configuration                                                   

    runtime/laos/src/configs/treasury.rs

    • Removed unused parameters and types.
    +1/-10   
    xcm_config.rs
    Add XcmRecorder to XCM Configuration                                         

    runtime/laos/src/configs/xcm_config.rs

    • Added XcmRecorder type to the configuration.
    +1/-0     
    lib.rs
    Add Initialize Pending Block Function                                       

    runtime/laos/src/lib.rs

    • Added initialize_pending_block function to runtime APIs.
    +4/-0     
    migrations.rs
    Add New Migration Type for XCMP Queue                                       

    runtime/laos/src/migrations.rs

    • Added new migration type MigrateV4ToV5.
    +9/-2     
    pallet_treasury.rs
    Remove Unused Treasury Weight Functions                                   

    runtime/laos/src/weights/pallet_treasury.rs

    • Removed weight functions for treasury proposals.
    +0/-45   
    mod.rs
    Add XcmRecorder to Asset Hub XCM Config                                   

    xcm-simulator/src/asset_hub/xcm_config/mod.rs

    • Added XcmRecorder type to the configuration.
    +1/-0     
    xcm_config.rs
    Add XcmRecorder to Laosish XCM Config                                       

    xcm-simulator/src/laosish/configs/xcm_config.rs

    • Added XcmRecorder type to the configuration.
    +1/-0     
    parachain.rs
    Add XcmRecorder to Parachain Config                                           

    xcm-simulator/src/parachain.rs

    • Added XcmRecorder type to the configuration.
    +1/-0     
    relay_chain.rs
    Add XcmRecorder to Relay Chain Config                                       

    xcm-simulator/src/relay_chain.rs

    • Added XcmRecorder type to the configuration.
    +1/-0     
    Configuration changes
    1 files
    download_polkadot.sh
    Update Default Polkadot SDK Version                                           

    zombienet/download_polkadot.sh

    • Updated default Polkadot SDK version to stable2407-3.
    +1/-1     
    Dependencies
    1 files
    Cargo.toml
    Update Dependencies to Stable2407 Branch                                 

    Cargo.toml

  • Updated Polkadot SDK dependencies to stable2407 branch.
  • Updated jsonrpsee version to 0.23.2.
  • +147/-147

    💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

    magecnion and others added 2 commits September 13, 2024 09:27
    …#778)
    
    * using runt 1.77
    
    * fix clippy errors
    
    * fixing clippy
    
    * update to runtime 2200
    
    * update proyect version to 0.22.0
    
    * add missing migration
    
    * removed the upgrade of versioning
    @asiniscalchi asiniscalchi marked this pull request as ready for review September 13, 2024 11:32
    @asiniscalchi
    Copy link
    Member

    /describe

    Copy link

    PR Description updated to latest commit (43737f3)

    @github-actions github-actions bot changed the title Upgrade polkadot-sdk to stable2407 Upgrade Polkadot SDK to Stable2407 and Enhance Runtime Configurations Sep 13, 2024
    @asiniscalchi
    Copy link
    Member

    /describe

    Copy link

    PR Description updated to latest commit (42e3392)

    asiniscalchi
    asiniscalchi previously approved these changes Sep 13, 2024
    Copy link
    Member

    @asiniscalchi asiniscalchi left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Treasury entry disappered
    image

    @asiniscalchi
    Copy link
    Member

    /describe

    @github-actions github-actions bot changed the title Upgrade Polkadot SDK to Stable2407 and Enhance Runtime Configurations Upgrade Polkadot SDK to Stable2407 and Enhance Configurations Nov 28, 2024
    Copy link

    PR Description updated to latest commit (5dc6e2b)

    @asiniscalchi asiniscalchi merged commit f824e61 into main Nov 29, 2024
    8 checks passed
    @asiniscalchi asiniscalchi deleted the feature/upgrade-polkadot-sdk-to-stable2407 branch November 29, 2024 09:52
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    Upgrade to Polkadot-SDK 2407
    4 participants