Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JSDoc to help IDE's to understand what's going on #1

Merged
merged 1 commit into from
Jul 3, 2017

Conversation

jdreesen
Copy link
Contributor

PhpStorm for example says Unresolved method or function addEventListener() when trying to call select('...').addEventListener(...) without the JSDoc.

@fregante
Copy link
Owner

Sounds good! However parent can also be an Array-like in select.all

@jdreesen
Copy link
Contributor Author

Oops, you are right, I updated the commit.

@fregante
Copy link
Owner

Excellent! One last thing. select() can also return null. How's that handled by JSDoc?

@jdreesen
Copy link
Contributor Author

Nullable types are prefixed with a ? as far as I know.

I updated the commit once again.

@fregante fregante merged commit ed41f56 into fregante:master Jul 3, 2017
@fregante
Copy link
Owner

fregante commented Jul 3, 2017

Thank you for the first PR of this repo! :)

Your changes are in 4.1.1

@jdreesen jdreesen deleted the patch-1 branch July 3, 2017 16:03
@fregante
Copy link
Owner

fregante commented Feb 1, 2019

Do you mind if I drop JSDoc in favor of TypeScript definition files? PhpStorm should work anyway, maybe better.

Also perhaps try #4 out

@jdreesen
Copy link
Contributor Author

jdreesen commented Feb 2, 2019

Of course not, go ahead. TypeScript definitions should be even better than JSDoc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants