Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

packages added by a patch will not be activated #734

Closed
SvenRoederer opened this issue Nov 20, 2019 · 2 comments
Closed

packages added by a patch will not be activated #734

SvenRoederer opened this issue Nov 20, 2019 · 2 comments

Comments

@SvenRoederer
Copy link
Contributor

In bfc8f48 a patch was added which implements openwrt/luci#2817. When building the firmware it fails with

Collected errors:

  • satisfy_dependencies_for: Cannot satisfy the following dependencies for luci-base:
  • luci-lib-base
  • opkg_install_cmd: Cannot install package luci-base.

As the package "luci-lib-base" is created by this patch by splitting some files from the original "luli-base" package.

@SvenRoederer
Copy link
Contributor Author

In PR #714 I changed the Makefile to apply the patches on the individual feeds and openwrt in contrast to our current way of using patches with openwrt as basedir (including the feeds). This makes it possible to patch the feeds independently from openwrt. In addition the PR is using some scripts from the @freifunk-gluon to apply the patches and update the source. The overall changes solving the problem of this issue, without runnig "feeds update" and "feeds install" multiple times.

SvenRoederer added a commit to SvenRoederer/freifunk-berlin-firmware that referenced this issue Dec 8, 2019
update the current targets to use the gluon-scripts for cloning,
patching and installing OpenWrt and feeds.

- target .stamp-feeds-updated, which is doing the whole update-steps,
  by depending on patch and prepare
  - update openwrt and feeds
  - patch openwrt and feeds
  - setup feeds within openwrt
- have target patch depend on the patches-files, to reapply them
  after they have changed (moved from target pre-patch)
- drop conflicting / superfluous targets
  - openwrt-update - handled by "patch"
  - $(OPENWRT_DIR) - handled by "patch"
  - $(OPENWRT_DIR)/patches - superfluous, by patching outside of OpenWrt-tree
  - $(OPENWRT_DIR)/feeds.conf - handled by "feeds-update"
  - unpatch - superfluous by not using quilt anymore
- extend target clean to remove added files / folders

Using the Gluon-toolset fixes issue freifunk-berlin#734, where feed-packages added
as patch have not been installed.
SvenRoederer added a commit to SvenRoederer/freifunk-berlin-firmware that referenced this issue Dec 8, 2019
update the current targets to use the gluon-scripts for cloning,
patching and installing OpenWrt and feeds.

- target .stamp-feeds-updated, which is doing the whole update-steps,
  by depending on patch and prepare
  - update openwrt and feeds
  - patch openwrt and feeds
  - setup feeds within openwrt
- have target patch depend on the patches-files, to reapply them
  after they have changed (moved from target pre-patch)
- drop conflicting / superfluous targets
  - openwrt-update - handled by "patch"
  - $(OPENWRT_DIR) - handled by "patch"
  - $(OPENWRT_DIR)/patches - superfluous, by patching outside of OpenWrt-tree
  - $(OPENWRT_DIR)/feeds.conf - handled by "feeds-update"
  - unpatch - superfluous by not using quilt anymore
- extend target clean to remove added files / folders

Using the Gluon-toolset fixes issue freifunk-berlin#734, where feed-packages added
as patch have not been installed.
SvenRoederer added a commit that referenced this issue Dec 8, 2019
SvenRoederer added a commit that referenced this issue Dec 8, 2019
@SvenRoederer
Copy link
Contributor Author

fixed by merging #714

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant