Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: add the new luci-app-opkg to all image types (luci-master) #627

Merged
merged 2 commits into from
Jun 3, 2019

Conversation

pmelange
Copy link
Contributor

@pmelange pmelange commented Nov 26, 2018

Do not merge until the firmware is based on OpenWRT 19.x

The comment from the upstream commit is:
Add a new luci-app-opkg which is a feature-complete replacement for the
builtin opkg functionality of luci-mod-system using mostly client side
JavaScript to reduce the amount of server side processing.

The upstream commit in openwrt/luci is openwrt/luci@aa2e0e2

The freifunk-berlin issue is #621

The comment from the upstream commit is:
Add a new luci-app-opkg which is a feature-complete replacement for the
builtin opkg functionality of luci-mod-system using mostly client side
JavaScript to reduce the amount of server side processing.

The upstream commit in openwrt/luci is openwrt/luci@aa2e0e2

The freifunk-berlin issue is #621
@SvenRoederer
Copy link
Contributor

This is only valid for luci-master, but not for 18.06-branch.

@SvenRoederer
Copy link
Contributor

We should not add this app for the "default-4MB" devices, as we remove the opkg system to gain some space.

@pmelange
Copy link
Contributor Author

Yes, this is needed for luci-master. Another thing is that PR freifunk-berlin/firmware-packages#158 needs to be merged before this will work.

@pmelange
Copy link
Contributor Author

A discussion about what to have in the 4MB images can be found in issue #626

@pmelange
Copy link
Contributor Author

Oh, I see new what you mean about the 4MB devices. There is another commit on it's way

…_4MB

Remove the app from targets default_4MB and tunnel-berlin-tunneldigger_4MB
to save space on the device.  The opkg system is anyhow being removed for
the same reason.
@pmelange
Copy link
Contributor Author

I left luci-app-opkg for the backbone_4MB targets since opkg is still added to these images

@pmelange pmelange changed the title build: add the new luci-app-opkg to all image types build: add the new luci-app-opkg to all image types (luci-master) Nov 26, 2018
@SvenRoederer SvenRoederer added this to the Hedy-1.2.0 milestone Mar 12, 2019
@sarumpaet sarumpaet merged commit a269987 into master Jun 3, 2019
@sarumpaet sarumpaet deleted the add_luci-app-opkg branch June 3, 2019 12:03
@pmelange
Copy link
Contributor Author

pmelange commented Jun 3, 2019

This commit needs to be reverted. The luci-app-opkg package is only to be found on the luci master branch (our master is on the 18.x branch). When OpenWrt 19.x is ready, then this commit should be merged.

Also note, the milestone is Hedy-1.2.0

@sarumpaet can you take care of the revert and restoring the branch?

@sarumpaet
Copy link
Contributor

Milestones have been largely fiction so far.
If you don't want something merged, please add "do not merge" to the PR subject.

@pmelange
Copy link
Contributor Author

pmelange commented Jun 3, 2019

comment has been updated. But I guess a new PR is needed since this one is closed.

@pmelange
Copy link
Contributor Author

pmelange commented Jun 3, 2019

the new PR is #692

@pmelange pmelange deleted the add_luci-app-opkg branch June 3, 2019 18:12
@sarumpaet
Copy link
Contributor

Thx and sorry!

@pmelange
Copy link
Contributor Author

pmelange commented Jun 3, 2019

no problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants