gluon-mesh-babel: Reduce load in respondd #1799
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
i just noticed that this PR contains parts that are not directly related to "reduce load", maybe you can split this apart and get parts merged faster and also reduce this PR's size? |
|
@t-8ch thank you for your review. Were all of your comments considered as intended? |
t-8ch
reviewed
Oct 16, 2019
t-8ch
reviewed
Oct 23, 2019
christf
force-pushed
the
loadfix
branch
2 times, most recently
from
fdbd254 to
5edb435
Compare
t-8ch
reviewed
Oct 31, 2019
t-8ch
approved these changes
Oct 31, 2019
|
unfortunately libjson-c 0.13 is not yet in relevant gluon versions for a while. only 0.13 includes json_object_deep_copy(). Because of this I introduced a fallback that should work with 0.12. Testing is in progress. |
christf
force-pushed
the
loadfix
branch
2 times, most recently
from
aaf6935 to
811e295
Compare
christf
force-pushed
the
loadfix
branch
2 times, most recently
from
672ca0e to
e222c64
Compare
rotanid
added
the
2. status: merge conflict
|
this needs a rebase now @christf |
* open babel socket in its own event loop, allowing to monitor instead of dump * keep state from monitor in json object, providing that to clients on network on demand * do not parse babel routes, instead use netlink to obtain nexthop babeld still does not support limiting the data on the socket by object. When that is merged, the load can be further reduced by limiting to neighbour changes with a small change.
This can be reverted after updating the package feed to something newer than 080ba31eec2ff4c165ce5a1bb9d434ddd91bdb6b from 2019-04-30 and should be in the upcoming openwrt release after 19.07
…abel After refactoring the respondd module to work with a separate thread, handle_neighbour() is different in those two programs. A common implemenation thus is impossible and the structure is removed.
…en unable to allocate memory for neighbour json We don't need a thread parsing babeld if there is not enough memory to store the results. Print an error message in this case andcontinue without neighbour information in respondd data
|
rebase is done. |
christf
added
2. status: waiting-on-review
|
See christf/libbabelhelper#9 for current progress on libbabelhelper cleanup. |
neocturne
added
2. status: blocked
rotanid
added
the
2. status: merge conflict
|
@christf needs rebase? |
25 tasks
AiyionPrime
added
the
2. status: waiting-on-author
|
Closed because of #3105 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reduces the load by: