Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lantiq devices as BROKEN #1803

Closed
wants to merge 1 commit into from
Closed

Conversation

heini66
Copy link
Contributor

@heini66 heini66 commented Aug 31, 2019

Patch 1 of 2
Addd initial lantiq support

Patch 1 of 2
Addd initial lantiq support
@heini66 heini66 changed the title Update targets.mk Add lantiq devices as BROKEN Aug 31, 2019
@heini66
Copy link
Contributor Author

heini66 commented Aug 31, 2019

flash sysupgrade via bootloader -> mtd1

@rotanid rotanid added the 3. topic: hardware Topic: Hardware Support label Aug 31, 2019
This was referenced Aug 31, 2019
@rotanid
Copy link
Member

rotanid commented Aug 31, 2019

you supply way too less information for two new targets and new devices.
please
a) check https://github.com/freifunk-gluon/gluon/wiki/Device-Integration
b) follow https://github.com/freifunk-gluon/gluon/wiki/Device-Integration-checklist
c) don't do PRs like this one here, which does not do anything with any effect on Gluon. This PR should have been split in half into your other two PRs, so the target and it's first device are added together. please do this together with b) , after you have read a). afterwards, we can close this PR here.

thank you for your contribution and for understanding my reasoning

@rotanid rotanid added the 2. status: blocked Marked as blocked because it's waiting on something label Aug 31, 2019
@heini66
Copy link
Contributor Author

heini66 commented Sep 1, 2019

thanks for your comments. i'll try to get my next pr a little bit more ...
might you vistit up in https://forum.freifunk.net/t/alte-fritzbox-als-freifunk-repeater/21154 to clearify some things? ;)

@blocktrron
Copy link
Member

Regarding the State of AVM lantiq boards in 18.06:

  1. Their naming is ... interesting. Describing boards with iterating marketing titles is not the kind of thing we want / need. However, conflicts have not arised (and the naming is fixed in https://git.openwrt.org/?p=openwrt/openwrt.git;a=commit;h=d4ba7bab25c84478ce3aa5ebd80d24b5a5624e7b )

  2. The LED mappings were very inconsistent, as the Power LED had duplicate mappings for indicating running as well as DSL state on some devices, on others DSL state was mapped on the Info LED. For us, this means no indication of setup mode on these boards. However, i've tried to clean up this mess here: https://git.openwrt.org/?p=openwrt/openwrt.git;a=commit;h=3032bf7f89e8ad5b69ab2f031287f475e5d2b829

@heini66
Copy link
Contributor Author

heini66 commented Sep 3, 2019 via email

@mweinelt
Copy link
Contributor

mweinelt commented Sep 3, 2019

Let's postpone this until after v2019.1, so we can base this on OpenWrt v19.0[789012].

@christf christf added the 2. status: waiting-on-author Waiting on some action from the author label Sep 23, 2019
@mweinelt
Copy link
Contributor

@heini66 Thank you for you interest in getting more devices upstream. I'm closing these pulls (#1803 #1804 #1805) because the form given isn't actionable to the Gluon maintainers.

Also please wait until we've merged #1791 and base your changes on that. Thank you!

@mweinelt mweinelt closed this Sep 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. status: blocked Marked as blocked because it's waiting on something 2. status: waiting-on-author Waiting on some action from the author 3. topic: hardware Topic: Hardware Support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants