gluon-config-mode-core: discard gluon-reconfigure output #2395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The stdout output of gluon-web scripts is directly sent to uhttpd, becoming a part of the HTML output or even replacing HTTP status or headers. The output of gluon-reconfigure is not supposed to end up there. While we're at it, also add an exec to avoid an unnecessary shell process.
neocturne
added
3. topic: package
github-actions
bot
removed
the
3. topic: config-mode
This was referenced Feb 15, 2022
skorpy2009
approved these changes
Feb 20, 2022
neocturne
added a commit
that referenced
this pull request
Feb 22, 2022
The stdout output of gluon-web scripts is directly sent to uhttpd, becoming a part of the HTML output or even replacing HTTP status or headers. The output of gluon-reconfigure is not supposed to end up there. While we're at it, also add an exec to avoid an unnecessary shell process. (cherry picked from commit eea49a2)
JayBraker
pushed a commit
to JayBraker/gluon
that referenced
this pull request
Apr 12, 2023
…uon#2395) The stdout output of gluon-web scripts is directly sent to uhttpd, becoming a part of the HTML output or even replacing HTTP status or headers. The output of gluon-reconfigure is not supposed to end up there. While we're at it, also add an exec to avoid an unnecessary shell process.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The stdout output of gluon-web scripts is directly sent to uhttpd,
becoming a part of the HTML output or even replacing HTTP status or
headers. The output of gluon-reconfigure is not supposed to end up
there.
While we're at it, also add an exec to avoid an unnecessary shell
process.
Extracted from #2372, as we'll also want to backport this commit to v2021.1.x as soon as possible.