Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ath79-generic: (re)add support for ALFA Network AP121F #2583

Merged
merged 2 commits into from
Jul 10, 2022
Merged

ath79-generic: (re)add support for ALFA Network AP121F #2583

merged 2 commits into from
Jul 10, 2022

Conversation

T-X
Copy link
Contributor

@T-X T-X commented Jul 10, 2022

  • Must be flashable from vendor firmware
  • Must support upgrade mechanism
    • Must have working sysupgrade
      • Must keep/forget configuration (sysupgrade [-n], firstboot)
    • Gluon profile name matches autoupdater image name
      (lua -e 'print(require("platform_info").get_image_name())')
  • Reset/WPS/... button must return device into config mode
  • Primary MAC address should match address on device label (or packaging)
    (https://gluon.readthedocs.io/en/latest/dev/hardware.html#notes)
    • When re-adding a device that was supported by an earlier version of Gluon, a
      factory reset must be performed before checking the primary MAC address, as
      the setting from the old version is not reset otherwise.
  • Wired network
    • should support all network ports on the device
    • must have correct port assignment (WAN/LAN)
      • On devices supplied via PoE, there is usually no explicit WAN/LAN labeling on the hardware.
        The PoE input should be the WAN port in this case.
  • Wireless network (if applicable)
    • Association with AP must be possible on all radios
    • Association with 802.11s mesh must work on all radios
    • AP+mesh mode must work in parallel on all radios
  • LED mapping
    • Power/system LED
    • Radio LEDs
      • Should map to their respective radio
      • Should show activity
    • Switch port LEDs
      • Should map to their respective port (or switch, if only one led present)
      • Should show link state and activity
  • Outdoor devices only:
    • Added board name to is_outdoor_device function in package/gluon-core/luasrc/usr/lib/lua/gluon/platform.lua
      • N/A, indoor, mini USB travel router

AiyionPrime and others added 2 commits July 10, 2022 23:22
@AiyionPrime @T-X
gluon-setup-mode: add fallback led-boot as status
26b5764 
for devices in targets that do no implement `get_status_led` in /etc/diag.sh
and do not have an led-running in their dts
@T-X
ath79-generic: (re)add support for ALFA Network AP121F
4cbd748 
Gone due to
commit 45c84a1 ("ar71xx: drop target")

Note that it was wrongly marked as device class tiny in
commit 7fd7116 ("targets: add device-class flags") in the past,
the device has 64MB RAM and not 32MB.

Also, the device has no "led-running" assigned in DTS. The device has
three LEDs: "green:vpn", "green:lan" and "green:wlan". The first LED,
"green:vpn", has a "V" icon and was used to show the VPN connection
status in the vendor firmware. This LED will be used via the newly
added "led-boot" fallback in gluon-setup-mode. But will be unused
during normal operation due to the unassigned "led-running" in DTS.

Signed-off-by: Linus Lüssing <[email protected]>
@github-actions github-actions bot added 3. topic: docs Topic: Documentation 3. topic: hardware Topic: Hardware Support 3. topic: package Topic: Gluon Packages labels Jul 10, 2022
AiyionPrime
AiyionPrime approved these changes Jul 10, 2022
View reviewed changes
Copy link
Member

@AiyionPrime AiyionPrime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"ALFA Network" does match their description on social media,
the S96 patch was tested before,
the target descriptions match the OpenWrt files.

lgtm.

This was referenced Jul 10, 2022
Merged
Open
@rotanid rotanid merged commit ac24b70 into freifunk-gluon:master Jul 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AiyionPrime AiyionPrime AiyionPrime approved these changes

Assignees
No one assigned
Labels
3. topic: docs Topic: Documentation 3. topic: hardware Topic: Hardware Support 3. topic: package Topic: Gluon Packages
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@T-X @AiyionPrime @rotanid