-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gluon-wireless-encryption{,-wpa3}: rename to match actual package name #2752
Conversation
@blocktrron Do you remember why the source and binary package names differ? |
I think one of the earlier drafts was more about holding the package generic, wpa2 and wpa3 were both "just" featuresets in the Makefile which could have been chosen from. You didn't like the approach and asked him to change it.
Originally posted by @NeoRaider in #1876 (comment) |
note that currently the old PKG_NAME is invalid but the -wpa3 one works despite that because (presumably) the call to BuildPackageGluon, which uses the right package name, still makes it a valid package |
the current wpa3 package adds the wpa3 file which the webui uses to check which encryptions are available. if there's a way to directly get this information from perhaps the hostapd library via a command/binding/whatever then that could also be used and the package could be dropped. |
This is available using |
Only merged pull requests can be backported. |
I wouldn't call it "invalid" - there is nothing wrong with source and binary package names not matching. Still, in this case there isn't a good reason to have them differ, so I merged this. |
No description provided.