Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gluon-wireless-encryption{,-wpa3}: rename to match actual package name #2752

Merged
merged 1 commit into from
Jan 11, 2023

Conversation

mkg20001
Copy link
Member

@mkg20001 mkg20001 commented Jan 6, 2023

No description provided.

@github-actions github-actions bot added the 3. topic: package Topic: Gluon Packages label Jan 6, 2023
@neocturne
Copy link
Member

@blocktrron Do you remember why the source and binary package names differ?

@AiyionPrime
Copy link
Member

AiyionPrime commented Jan 6, 2023

I think one of the earlier drafts was more about holding the package generic, wpa2 and wpa3 were both "just" featuresets in the Makefile which could have been chosen from.

You didn't like the approach and asked him to change it.

Having a wpa2 feature at all does not make sense to me; making it a part of the wpa3 as well package even less.

Let's drop the flag and the package, and directly reference hostapd-mini in package/features.

Originally posted by @NeoRaider in #1876 (comment)

@AiyionPrime AiyionPrime requested a review from blocktrron January 6, 2023 17:06
@AiyionPrime AiyionPrime added the 2. status: waiting-on-review Awaiting review from the assignee but also interested parties. label Jan 10, 2023
@mkg20001
Copy link
Member Author

note that currently the old PKG_NAME is invalid but the -wpa3 one works despite that because (presumably) the call to BuildPackageGluon, which uses the right package name, still makes it a valid package

@mkg20001
Copy link
Member Author

the current wpa3 package adds the wpa3 file which the webui uses to check which encryptions are available. if there's a way to directly get this information from perhaps the hostapd library via a command/binding/whatever then that could also be used and the package could be dropped.

@blocktrron
Copy link
Member

This is available using hostapd -vsae. However, we can not drop this package, as it is required for adding the appropriate hostapd version.

@neocturne neocturne merged commit 133ddf1 into freifunk-gluon:master Jan 11, 2023
@github-actions
Copy link

Only merged pull requests can be backported.

@neocturne
Copy link
Member

note that currently the old PKG_NAME is invalid but the -wpa3 one works despite that because (presumably) the call to BuildPackageGluon, which uses the right package name, still makes it a valid package

I wouldn't call it "invalid" - there is nothing wrong with source and binary package names not matching. Still, in this case there isn't a good reason to have them differ, so I merged this.

@mkg20001 mkg20001 deleted the wpa3 branch January 12, 2023 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0. type: question 2. status: waiting-on-review Awaiting review from the assignee but also interested parties. 3. topic: package Topic: Gluon Packages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants