Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gluon-core: sleep to wait for device initialisations #2792

Merged
merged 1 commit into from
Feb 25, 2023
Merged

gluon-core: sleep to wait for device initialisations #2792

merged 1 commit into from
Feb 25, 2023

Conversation

rotanid
Copy link
Member

@rotanid rotanid commented Feb 20, 2023

workaround for a timing issue during first boot on ath79-generic after sysupgrade from ar71xx-generic image

GitHub Issue: #2779

@rotanid rotanid added 3. topic: hardware Topic: Hardware Support 0. type: bugfix This changeset fixes abug backport v2022.1.x Backport this pull request to v2022.1.x labels Feb 20, 2023
@rotanid rotanid added this to the 2022.1.3 milestone Feb 20, 2023
@github-actions github-actions bot added 3. topic: package Topic: Gluon Packages and removed 3. topic: hardware Topic: Hardware Support labels Feb 20, 2023
@rotanid rotanid mentioned this pull request Feb 20, 2023
Open
@herbetom
Copy link
Contributor

This means every gluon-reconfigure will need at least 3 seconds to return?

As a quick solution for v2022.1.3 this could be okay, but i would prefer a bit more intelligence over the duration for a longer-term solution.

@rotanid
Copy link
Member Author

rotanid commented Feb 21, 2023

This means every gluon-reconfigure will need at least 3 seconds to return?

As a quick solution for v2022.1.3 this could be okay, but i would prefer a bit more intelligence over the duration for a longer-term solution.

see #2779 (comment)

@rotanid rotanid added the 3. topic: hardware Topic: Hardware Support label Feb 21, 2023
@neocturne
Copy link
Member

How about adding the sleep to zzz-gluon-upgrade instead? That way it would only apply to the run after a firmware update.

@neocturne neocturne added the 2. status: waiting-on-author Waiting on some action from the author label Feb 22, 2023
@rotanid rotanid force-pushed the master-ath79-bugfix branch from a0f1933 to 32cb14f Compare February 25, 2023 02:00
@github-actions github-actions bot removed the 3. topic: hardware Topic: Hardware Support label Feb 25, 2023
@rotanid rotanid changed the title gluon-core: wireless-migration: sleep to wait for device initialisations gluon-core: sleep to wait for device initialisations Feb 25, 2023
@rotanid rotanid removed the 2. status: waiting-on-author Waiting on some action from the author label Feb 25, 2023
@rotanid
Copy link
Member Author

rotanid commented Feb 25, 2023

How about adding the sleep to zzz-gluon-upgrade instead? That way it would only apply to the run after a firmware update.

@NeoRaider
done.
i also tested lower sleep second values, but with 1 second i still had the problem so i went with 3 seconds again to be safe.

AiyionPrime
AiyionPrime approved these changes Feb 25, 2023
View reviewed changes
Copy link
Member

@AiyionPrime AiyionPrime left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure spelling matters here; this will hopefully be gone soon either way.

@rotanid I assume you tested not only lower seconds but with the new placement in zzz-gluon-upgrade as well?

@AiyionPrime AiyionPrime added 0. type: question 2. status: waiting-on-author Waiting on some action from the author labels Feb 25, 2023
@AiyionPrime
Copy link
Member

Ah, if you go for replacing the s with a z, the commit message could use it as well.

@rotanid
gluon-core: sleep a few seconds during upgrade
d97673f 
wait for device initialisations
workaround for a timing issue during first boot on ath79-generic
after sysupgrade from ar71xx-generic image

GitHub Issue: #2779
@rotanid rotanid force-pushed the master-ath79-bugfix branch from 32cb14f to d97673f Compare February 25, 2023 23:05
@rotanid
Copy link
Member Author

rotanid commented Feb 25, 2023 •
edited
Loading

@rotanid I assume you tested not only lower seconds but with the new placement in zzz-gluon-upgrade as well?

yes, i only tested with the new placement, not the old one.

@AiyionPrime AiyionPrime merged commit f71e31a into master Feb 25, 2023
@github-actions github-actions bot mentioned this pull request Feb 25, 2023
Merged
@github-actions
Copy link

Successfully created backport PR for v2022.1.x:

@neocturne neocturne deleted the master-ath79-bugfix branch February 25, 2023 23:14
@rotanid rotanid removed the 2. status: waiting-on-author Waiting on some action from the author label Feb 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neocturne neocturne neocturne approved these changes

@AiyionPrime AiyionPrime AiyionPrime approved these changes

Assignees
No one assigned
Labels
0. type: bugfix This changeset fixes abug 3. topic: package Topic: Gluon Packages backport v2022.1.x Backport this pull request to v2022.1.x
Projects
None yet
Milestone
2022.1.3
Development

Successfully merging this pull request may close these issues.
4 participants
@rotanid @herbetom @neocturne @AiyionPrime