Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Github Action GITHUB_SHA #567

Closed
T0biii opened this issue Jan 21, 2025 · 0 comments · Fixed by #568
Closed

Github Action GITHUB_SHA #567

T0biii opened this issue Jan 21, 2025 · 0 comments · Fixed by #568
Labels
bug gluon-v2021.1.x Applies on 4/32 branch gluon-v2023.1.x gluon-v2023.2.x

Comments

@T0biii
Copy link
Member

T0biii commented Jan 21, 2025 •
edited
Loading

The Firmware-Version seems to be a bit of, the git describe --tags in the makefile via Github Actions provides a different GITHUB_SHA Value then the last commit in the PR

https://github.com/freifunkMUC/site-ffm/blob/gluon-v2023.2.x/.github/workflows/firmware.yml#L61

3f9bce8
Image
ddf3c15
Image

3f9bce8 != ddf3c15

More Info:

But this is not the GITHUB_SHA for pull_request event. The GITHUB_REF for pull_request event is PR merge branch refs/pull/:prNumber/merge. And the GITHUB_SHA is the last merge commit on the GITHUB_REF branch. This GITHUB_SHA does not exist in any current branch in repo. So you will get fatal: bad object.

Solution:

https://github.com/ridedott/merge-me-action/blob/17b44e0eb9b0935781e34684ce4433b431014006/README.md?plain=1#L134-L135
T0biii added a commit that referenced this issue Jan 21, 2025
@T0biii
update GITHUB_SHA ENV
f5b33fb 
fixes #567
@T0biii T0biii mentioned this issue Jan 21, 2025
Merged
T0biii added a commit that referenced this issue Jan 22, 2025
@T0biii
update GITHUB_SHA ENV
7542860 
fixes #567
T0biii added a commit that referenced this issue Jan 22, 2025
@T0biii
update GITHUB_SHA ENV
a89c374 
fixes #567
@Davidjennison1 Davidjennison1 mentioned this issue Jan 25, 2025
Open
@freifunkMUC freifunkMUC deleted a comment from Davidjennison1 Jan 25, 2025
@T0biii T0biii closed this as completed in ee286f0 Jan 25, 2025
T0biii added a commit that referenced this issue Jan 25, 2025
@T0biii
update GITHUB_SHA ENV
ff05b36 
fixes #567
T0biii added a commit that referenced this issue Jan 25, 2025
@T0biii
update GITHUB_SHA ENV
f711370 
fixes #567
T0biii added a commit that referenced this issue Jan 28, 2025
@T0biii
update GITHUB_SHA ENV
a8e65ea 
fixes #567
ffmuc-bot bot pushed a commit that referenced this issue Jan 28, 2025
@T0biii @github-actions
update GITHUB_SHA ENV
b85999e 
fixes #567

(cherry picked from commit ee286f0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug gluon-v2021.1.x Applies on 4/32 branch gluon-v2023.1.x gluon-v2023.2.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[CI] update GITHUB_SHA ENV freifunkMUC/site-ffm
1 participant
@T0biii