Upgrade Docker image to NodeJS 17 #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DasSkelett
added
dependencies
GoliathLabs
approved these changes
Jan 3, 2022
There was a problem hiding this comment.
@DasSkelett Haven't tested it yet but if you have already and things seem to work, I'll approve 😅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The upgrade to NodeJS 17 has been blocked by
create-react-app/react-scripts: #22There were some changes in Node 17, most importantly it switched to OpenSSL 3.0, which removed a bunch of older Hash functions that some Node packages like webpack relied on.
create-react-app5.0.0 has switched to a newer webpack release, and as far as I can tell works on Node 17 (and 16) now.Changes
react-scriptsis upgraded to^5.0.0.@types/reactand@types/react-domare upgraded to their latest 17.x release, to match their non-types counterparts.The frontend files are built using Node17 in the Docker image.
Closes #22