Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump bootstrap from 4.6.2 to 5.3.3 #36

Merged
merged 1 commit into from
Dec 29, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Dec 9, 2024

This is mainly done.

Bumps bootstrap from 3.3.6 to 5.3.3.

Release notes

Sourced from bootstrap's releases.

v5.3.3

Highlights

  • Fixed a breaking change introduced with color modes where it was required to manually import variables-dark.scss when building Bootstrap with Sass. Now, _variables.scss will automatically import _variables-dark.scss. If you were already importing _variables-dark.scss manually, you should keep doing it as it won't break anything and will be the way to go in v6.
  • Fixed a regression in the selector engine that wasn't able to handle multiple IDs anymore.

Color modes

  • Badges now use the .text-bg-* text utilities to be certain that the text is always readable (especially when the customized colors are different in light and dark modes).
  • Fixed our color-modes.js script to handle the case where the OS is set to light mode and the auto color mode is used on the website. If you copied the script from our docs, you should apply this change to your own script.
  • Fixed color schemes description in the color modes documentation to show that color-scheme() only accept light and dark values as parameters.

Miscellaneous

  • Allowed <dl>, <dt> and <dd> in the sanitizer.
  • Dropped evenly items distribution for modal and offcanvas headers.
  • Fixed the accordion CSS selectors to avoid inheritance issues when nesting accordions.
  • Fixed the focus box-shadow for the validation stated form controls.
  • Fixed the focus ring on focused checked buttons.
  • Fixed the product example mobile navbar toggler.
  • Changed the RTL processing of carousel control icons.

🎨 CSS

  • #37508: Use child combinators to avoid inheriting parent accordion's flush styles
  • #38719: Fix focus box-shadow for validation stated form-controls
  • #38884: fix border-radius on radio-switch
  • #39294: Tests: update navbar in visual modal test
  • #39373: refactor css: modal and offcanvas header spacing
  • #39380: Fix Sass compilation breaking change in v5.3
  • #39387: docs: fix typo
  • #39411: Optimize the accordion icon
  • #39497: Fix a typo
  • #39536: Changed RTL processing of carousel control icons
  • #39560: Drop --bs-accordion-btn-focus-border-color and deprecate $accordion-button-focus-border-color
  • #39595: CSS: Fix the focus ring on focused checked buttons

☕️ JavaScript

  • #39201: Selector Engine: fix multiple IDs
  • #39224: Fix edge case in color-mode.js
  • #39376: Allow dl, dt and dd in sanitizer

📖 Docs

  • #39200: Typo Fix
  • #39214: Doc: use .text-bg-{color} for all badges
  • #39246: Docs: fix for example code blocks have unnecessary 30px right-margin

... (truncated)

Commits
  • 6e1f75f Release v5.3.3 (#39524)
  • 3caef2b Build(deps-dev): Bump terser from 5.27.1 to 5.27.2 (#39690)
  • 4abac9b Build(deps-dev): Bump ip from 2.0.0 to 2.0.1 (#39691)
  • c396a2a Build(deps-dev): Bump sass from 1.70.0 to 1.71.0 (#39684)
  • c9a8a40 Build(deps-dev): Bump rollup from 4.9.6 to 4.12.0 (#39683)
  • 6aecb37 Build(deps-dev): Bump eslint-plugin-html from 7.1.0 to 8.0.0 (#39672)
  • 4081168 Build(deps-dev): Bump terser from 5.27.0 to 5.27.1 (#39682)
  • 4605d71 Build(deps-dev): Bump postcss from 8.4.34 to 8.4.35 (#39673)
  • 08eeee3 Build(deps-dev): Bump lockfile-lint from 4.12.1 to 4.13.1 (#39675)
  • f92d635 Build(deps-dev): Bump eslint-plugin-unicorn from 51.0.0 to 51.0.1 (#39676)
  • Additional commits viewable in compare view
Maintainer changes

This version was pushed to npm by xhmikosr, a new releaser for bootstrap since your current version.


Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Dec 9, 2024
Copy link
Member

@AiyionPrime AiyionPrime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same bug as in #31, cant merge this

@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/bootstrap-5.3.3 branch from fc7cf57 to e5e06dd Compare December 9, 2024 23:58
@AiyionPrime
Copy link
Member

@dependabot recreate

@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/bootstrap-5.3.3 branch 4 times, most recently from 5e4a040 to 6b9b360 Compare December 10, 2024 20:17
@AiyionPrime
Copy link
Member

@dependabot rebase

@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/bootstrap-5.3.3 branch 6 times, most recently from da8163e to 8f89ade Compare December 13, 2024 14:39
@AiyionPrime AiyionPrime force-pushed the dependabot/npm_and_yarn/bootstrap-5.3.3 branch from 8f89ade to 28f19af Compare December 13, 2024 15:41
@AiyionPrime

This comment was marked as outdated.

@AiyionPrime
Copy link
Member

@dependabot recreate

@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/bootstrap-5.3.3 branch from 28f19af to 0f5e0de Compare December 15, 2024 15:32
@AiyionPrime AiyionPrime changed the title Bump bootstrap from 3.3.6 to 5.3.3 Bump bootstrap from 4.6.2 to 5.3.3 Dec 15, 2024
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/bootstrap-5.3.3 branch from 0f5e0de to cea5983 Compare December 15, 2024 19:08
@AiyionPrime AiyionPrime force-pushed the dependabot/npm_and_yarn/bootstrap-5.3.3 branch from cea5983 to 6fc7276 Compare December 15, 2024 20:42
@AiyionPrime

This comment was marked as duplicate.

@AiyionPrime
Copy link
Member

@dependabot recreate

@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/bootstrap-5.3.3 branch from 864c64e to 91822dd Compare December 28, 2024 16:38
@AiyionPrime
Copy link
Member

@dependabot rebase

@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/bootstrap-5.3.3 branch from 91822dd to d64342f Compare December 28, 2024 16:53
@AiyionPrime AiyionPrime force-pushed the dependabot/npm_and_yarn/bootstrap-5.3.3 branch 3 times, most recently from c9cc1c3 to 396a9ec Compare December 28, 2024 17:40
@AiyionPrime
Copy link
Member

furthermore there's a styling issue with clicked navbar elements being black instead of white, and not being updated by the scroll-spy correctly.

https://github.com/freifunkh/fnorden.net/compare/c9cc1c36015abfb3fbc6c827437a559cac24b70d..396a9ec55fe58b609f9edc26a7ce40f78cd6f243

@AiyionPrime AiyionPrime force-pushed the dependabot/npm_and_yarn/bootstrap-5.3.3 branch from 396a9ec to bd1206f Compare December 28, 2024 18:35
@AiyionPrime AiyionPrime force-pushed the dependabot/npm_and_yarn/bootstrap-5.3.3 branch from bd1206f to 8f7c70e Compare December 28, 2024 18:38
@AiyionPrime AiyionPrime requested a review from moridius December 28, 2024 18:41
@AiyionPrime
Copy link
Member

@moridius alles im vendor Ordner ignorieren. Der ist autogeneriert und wird durch einen github check validiert.

@AiyionPrime
Copy link
Member

gerne einmal lokal auschecken und einen python webserver starten (siehe readme.md)

Copy link
Member

@AiyionPrime AiyionPrime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ich denke, so passts. Guckt mal nach, ob sich die Seite noch benimmt wie vorher.

@AiyionPrime AiyionPrime requested review from lemoer and 1977er December 28, 2024 22:14
Copy link
Member

@1977er 1977er left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

¯_(ツ)_/¯

@AiyionPrime AiyionPrime merged commit 5e5b134 into master Dec 29, 2024
3 checks passed
@AiyionPrime AiyionPrime deleted the dependabot/npm_and_yarn/bootstrap-5.3.3 branch December 29, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants