Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: migrate to @chainsafe/is-ip #21

Merged
merged 3 commits into from
Nov 13, 2022

Conversation

twoeths
Copy link
Contributor

@twoeths twoeths commented Oct 28, 2022

Motivation

  • is-ip 4.0.0 is the last performant version of is-ip (version 5.0.0 has a performance issue)
  • use @chainsafe/is-ip which is significantly faster

Description
Migrate to is-ip 4.0.0
Migrate to @chainsafe/is-ip

@wemeetagain
Copy link

@tuyennhv can you use @chainsafe/is-ip v2.0.1?

@twoeths
Copy link
Contributor Author

twoeths commented Nov 1, 2022

migrated to @chainsafe/is-ip as it's significantly faster, see ChainSafe/is-ip#1

@twoeths twoeths changed the title chore: migrate to is-ip 4.0.0 chore: migrate to @chainsafe/is-ip Nov 1, 2022
@frenchbread
Copy link
Owner

frenchbread commented Nov 9, 2022

Thanks @tuyennhv & @wemeetagain a lot for the contribution!

@chainsafe/is-ip appears to be an ESM module which private-ip does not support at this point. Would you mind converting this package to esm package? (reference pure ESM). Preferably supporting both cjs & esm.

@frenchbread
Copy link
Owner

Great work, thanks!

@frenchbread frenchbread merged commit ab988d1 into frenchbread:master Nov 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants