Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to disable_protection for a specific duration #1030

Closed
rbeuque74 opened this issue May 3, 2024 · 7 comments
Closed

Allow to disable_protection for a specific duration #1030

rbeuque74 opened this issue May 3, 2024 · 7 comments
Labels
stale There has not been activity on this issue or PR for quite some time.

Comments

@rbeuque74
Copy link

Problem/Motivation

Since AGH v0.107.28, AGH allow to disable protection for a specific duration (see AdguardTeam/AdGuardHome#1333).
This option is not present in disable_protection, hence, cannot be used in Home Assistant, using a service.

Expected behavior

Having an optional pause_duration_miliseconds parameter.

Proposed changes

  • switch URL to POST /protection
  • add an optional parameter to disable_protection
rbeuque74 added a commit to rbeuque74/python-adguardhome that referenced this issue May 3, 2024
@rbeuque74
feat: add disable protection for a specific duration
c88ee02 
Fixes frenck#1030

Signed-off-by: Romain Beuque <[email protected]>
rbeuque74 added a commit to rbeuque74/python-adguardhome that referenced this issue May 3, 2024
@rbeuque74
feat: add disable protection for a specific duration
e625d71 
Fixes frenck#1030

Signed-off-by: Romain Beuque <[email protected]>
@rbeuque74 rbeuque74 mentioned this issue May 3, 2024
Closed
rbeuque74 added a commit to rbeuque74/python-adguardhome that referenced this issue May 3, 2024
@rbeuque74
feat: add disable protection for a specific duration
d106c05 
Fixes frenck#1030

Signed-off-by: Romain Beuque <[email protected]>
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 3, 2024

There hasn't been any activity on this issue recently, so we clean up some of the older and inactive issues.
Please make sure to update to the latest version and check if that solves the issue. Let us know if that works for you by leaving a comment 👍
This issue has now been marked as stale and will be closed if no further activity occurs. Thanks!

@github-actions github-actions bot added the stale There has not been activity on this issue or PR for quite some time. label Jun 3, 2024
@rbeuque74
Copy link
Author

Hello,
This feature request is still relevant as it hasn't been addressed in the commits of this month.

Thanks
Romain

@github-actions github-actions bot removed the stale There has not been activity on this issue or PR for quite some time. label Jun 5, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 5, 2024

There hasn't been any activity on this issue recently, so we clean up some of the older and inactive issues.
Please make sure to update to the latest version and check if that solves the issue. Let us know if that works for you by leaving a comment 👍
This issue has now been marked as stale and will be closed if no further activity occurs. Thanks!

@github-actions github-actions bot added the stale There has not been activity on this issue or PR for quite some time. label Jul 5, 2024
rbeuque74 added a commit to rbeuque74/python-adguardhome that referenced this issue Jul 5, 2024
@rbeuque74
feat: add disable protection for a specific duration
cfde895 
Fixes frenck#1030

Signed-off-by: Romain Beuque <[email protected]>
@rbeuque74
Copy link
Author

Hello,
This feature request is still relevant as it hasn't been addressed in the commits of this month.

Thanks
Romain

@github-actions github-actions bot removed the stale There has not been activity on this issue or PR for quite some time. label Jul 6, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 6, 2024

There hasn't been any activity on this issue recently, so we clean up some of the older and inactive issues.
Please make sure to update to the latest version and check if that solves the issue. Let us know if that works for you by leaving a comment 👍
This issue has now been marked as stale and will be closed if no further activity occurs. Thanks!

@github-actions github-actions bot added the stale There has not been activity on this issue or PR for quite some time. label Aug 6, 2024
@rbeuque74
Copy link
Author

Hello,
This feature request is still relevant as it hasn't been addressed in the commits of this month.

Thanks
Romain

@github-actions github-actions bot removed the stale There has not been activity on this issue or PR for quite some time. label Aug 7, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 7, 2024

There hasn't been any activity on this issue recently, so we clean up some of the older and inactive issues.
Please make sure to update to the latest version and check if that solves the issue. Let us know if that works for you by leaving a comment 👍
This issue has now been marked as stale and will be closed if no further activity occurs. Thanks!

@github-actions github-actions bot added the stale There has not been activity on this issue or PR for quite some time. label Sep 7, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Sep 14, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Oct 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
stale There has not been activity on this issue or PR for quite some time.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add disable protection for a specific duration rbeuque74/python-adguardhome
1 participant
@rbeuque74