Skip to content

Commit

Permalink
Fix pip seeder with --extra-search-dir specified
Browse files Browse the repository at this point in the history
pip needs to have `--find-links` CLI argument for each directory
not just once for a list of directories.

Fixes: pypa#1834
  • Loading branch information
frenzymadness committed May 20, 2020
1 parent 078ed06 commit 857d083
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/virtualenv/seed/embed/pip_invoke.py
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ def get_pip_install_cmd(self, exe, version):
folders = set()
for context in (ensure_file_on_disk(get_bundled_wheel(p, version), self.app_data) for p in pkg_versions):
folders.add(stack.enter_context(context).parent)
folders.update(set(self.extra_search_dir))
for folder in folders:
cmd.extend(["--find-links", str(folder)])
cmd.extend(self.extra_search_dir)
yield cmd

0 comments on commit 857d083

Please sign in to comment.