Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature]: Passkey - Finishing checks and cleanup and documentation #2032

Closed
5 tasks done
aramikm opened this issue Jun 13, 2024 · 1 comment · Fixed by #2102
Closed
5 tasks done

[Feature]: Passkey - Finishing checks and cleanup and documentation #2032

aramikm opened this issue Jun 13, 2024 · 1 comment · Fixed by #2102
Milestone
Passkey Signature...

Comments

@aramikm
Copy link
Collaborator

aramikm commented Jun 13, 2024 •
edited
Loading

Feature Description

In this issue we would like to re-check all assumptions and done the finishing clean-up and adding left-over documentations

Acceptance Criteria

  • Filter inner calls just like what we do for token accounts
  • All modules and implementations should have concise and readable documents
  • All combinations of transactions and validations should get checked to ensure there are no known leftover vulnerabilities
  • Finishing cleanup and refactoring if required
  • Readme matches the Pallet Readme template
@aramikm aramikm mentioned this issue Jun 27, 2024
Merged
4 tasks
@shannonwells
Copy link
Collaborator

Just putting this here as a reminder. In #2047, I noticed several validations in passkey/src/lib.rs that can be turned into one-liners, some if/elses that can be replaced with ensure!, etc.

@aramikm aramikm mentioned this issue Jul 6, 2024
Merged
3 tasks
aramikm added a commit that referenced this issue Jul 10, 2024
@aramikm
passkey check weights (#2059)
d2bef1b 
# Goal
The goal of this PR is <!-- insert goal here -->

Related to #2032 

# Discussion
- Checks the blocks limits
- The `post_dispatch` is not added to the extrinsic yet due to
constraint complications but it will be done a different PR related
ticket #2063

# Checklist
- [x] Chain spec updated
- [x] Tests added
- [x] Weights updated
@aramikm aramikm mentioned this issue Jul 10, 2024
Merged
1 task
aramikm added a commit that referenced this issue Jul 11, 2024
@aramikm
passkeys: cleanup tests (#2068)
3ebbb71 
# Goal
The goal of this PR is to clean up tests and use Builder pattern to
setup the test

Related to #2032 


# Checklist
- [x] Tests Updated
@aramikm aramikm mentioned this issue Jul 11, 2024
Merged
aramikm added a commit that referenced this issue Jul 12, 2024
@aramikm
passkey: reorder validation and some docs (#2071)
d8faae7 
# Goal
The goal of this PR is to re order the validations to be as close as
possible to the signed extension order considering the customizations
that we did such as not having post_dispatch implemented.

Related to #2032
@saraswatpuneet saraswatpuneet mentioned this issue Jul 15, 2024
Merged
6 tasks
@aramikm aramikm mentioned this issue Jul 15, 2024
Merged
1 task
aramikm added a commit that referenced this issue Jul 16, 2024
@aramikm
passkeys: calculate weights (#2077)
b242c20 
# Goal
The goal of this PR is to calculate accurate weights for passkey pallet

Related to #2032

# Checklist
- [x] Weights updated

---------

Co-authored-by: aramikm <[email protected]>
saraswatpuneet added a commit that referenced this issue Jul 17, 2024
@saraswatpuneet @aramikm
Passkey e2e (#2070)
6fde4cf 
# Goal
The goal of this PR is to add e2e tests for passkey pallet

Details
-  Added 3 Negative tests and One happy path test

Part of #2032 

# Checklist
- [ ] Chain spec updated
- [ ] Custom RPC OR Runtime API added/changed? Updated js/api-augment.
- [ ] Design doc(s) updated
- [x] Tests added
- [ ] Benchmarks added
- [ ] Weights updated

---------

Co-authored-by: Aramik <[email protected]>
@aramikm aramikm mentioned this issue Jul 29, 2024
Merged
1 task
@aramikm aramikm mentioned this issue Jul 31, 2024
Merged
aramikm added a commit that referenced this issue Jul 31, 2024
@aramikm
passkey: simplify filter (#2106)
822915e 
# Goal
The goal of this PR is to simplify the extrinsic filter for passkeys

Related to #2032
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Passkey Signature Transaction Support
Development

Successfully merging a pull request may close this issue.

passkey: whitelisted capacity frequency-chain/frequency
2 participants
@shannonwells @aramikm