Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pre upgrade schema #1825

Merged
merged 2 commits into from
Dec 22, 2023
Merged

Fix pre upgrade schema #1825

merged 2 commits into from
Dec 22, 2023

Conversation

aramikm
Copy link
Collaborator

@aramikm aramikm commented Dec 21, 2023

Goal

The goal of this PR is to fix the pre migration issue that somehow got slipped into main branch.
An example of the error is the following:

2023-12-21 20:34:20 Running pre_upgrade...
2023-12-21 20:34:20 (key, value) failed to decode at [238, 198, 243, 193, 61, 38, 174, 37, 7, 201, 155, 103, 81, 225, 158, 118, 13, 72, 203, 53, 182, 108, 220, 238, 63, 151, 213, 0, 114, 204, 79, 216, 6, 164, 163, 214, 215, 161, 241, 20, 108, 0]: Error
2023-12-21 20:34:20 (key, value) failed to decode at [238, 198, 243, 193, 61, 38, 174, 37, 7, 201, 155, 103, 81, 225, 158, 118, 13, 72, 203, 53, 182, 108, 220, 238, 63, 151, 213, 0, 114, 204, 79, 216, 7, 99, 201, 131, 129, 220, 137, 171, 101, 0]: Error
[More with other at values]

Related to #1693

Discussion

Checklist

  • try-runtime was updated

verification

The try-runtime works as expected

Screenshot 2023-12-21 at 1 53 04 PM

@aramikm aramikm requested a review from wilwade as a code owner December 21, 2023 22:00
@aramikm aramikm requested a review from a team December 21, 2023 22:00
Copy link

codecov bot commented Dec 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (928f35d) 82.43% compared to head (1032131) 82.43%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1825   +/-   ##
=======================================
  Coverage   82.43%   82.43%           
=======================================
  Files          53       53           
  Lines        4087     4087           
=======================================
  Hits         3369     3369           
  Misses        718      718           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@enddynayn enddynayn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Collaborator

@mattheworris mattheworris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 it

  • Executed try-runtime and verified migrations completed without decode errors.

@aramikm aramikm merged commit f45a2b5 into main Dec 22, 2023
30 checks passed
@aramikm aramikm deleted the fix_pre_upgrade_schema branch December 22, 2023 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants