Feat/rename staking to provider boost #1976 #1977
Conversation
shannonwells
changed the base branch from
main
to
feat/capacity-staking-rewards-impl
pallets/capacity/src/lib.rs
Outdated
|
|
||
| /// The StakingRewardsProvider used by this pallet in a given runtime | ||
| type RewardsProvider: StakingRewardsProvider<Self>; | ||
| /// The BoostingRewardsProvider used by this pallet in a given runtime |
There was a problem hiding this comment.
I called it "BoostingRewardsProvider" because "ProviderBoostRewardsProvider" seemed a bit much. Welcoming alternatives.
There was a problem hiding this comment.
I prefer ProviderBoostRewardsProvider it reads better.
pallets/capacity/src/lib.rs
Outdated
| @@ -198,10 +198,10 @@ pub mod pallet { | |||
| /// Note that you can claim rewards even if you no longer are boosting, because you | |||
| /// may claim rewards for past eras up to the history limit. | |||
| #[pallet::constant] | |||
| type StakingRewardsPastErasMax: Get<u32>; | |||
| type ProviderBoostRewardsPastErasMax: Get<u32>; | |||
There was a problem hiding this comment.
"BoostingRewardsPastErasMax"? Or "ProviderBoostHistoryLimit" or "ProviderBoostHistorySize", or ?
There was a problem hiding this comment.
I like ProviderBoostHistoryLimit.
There was a problem hiding this comment.
I agree with Enddy.
Codecov ReportAttention: Patch coverage is
|
github-actions
bot
added
metadata-changed
shannonwells
removed
metadata-changed
| @@ -285,7 +285,7 @@ pub mod pallet { | |||
| /// Reward Pool history | |||
| #[pallet::storage] | |||
| #[pallet::getter(fn get_reward_pool_for_era)] | |||
| pub type StakingRewardPool<T: Config> = | |||
| pub type ProviderBoostRewardPool<T: Config> = | |||
There was a problem hiding this comment.
Maybe the plural is better, ProviderBoostRewardPools, because it stores multiple RewardPoolInfo records.
Goal
The goal of this PR is to unify naming for the Provider Boost feature. Everything that was called St*ing Rewards is now ProviderBoost or Boosting Rewards
Part of #1976
Discussion
Only renames. Also seeking alternate suggestions.