Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/reward pool refactor #1976 #2005

Conversation

shannonwells
Copy link
Collaborator

@shannonwells shannonwells commented Jun 5, 2024

Goal

The goal of this PR is to implement a "chunk" version of the overall reward pool history to reduce read/write load and hence weight for transactions and on_initialize when a new RewardEra needs to start.

Part of #1976

Discussion

This is is just one part of optimizing storage access. There will be more work later.

The current era Reward Pool and a ProviderBoostHistories record are updated on every provider_boost and unstake (for a boost account) call.

Instead of storing all overall Reward Pool history in a single CountedStorageMap, store the current total stake for the current era separately, and divide the actual past era history up into BoundedBTrees. The BTrees are of size RewardPoolChunkLength. These are in a StorageMap indexed by a u32 which is just the chunk index from 0 to history-size/chunk-length - 1.

This is unsurprisingly more complicated than the original solution, however it does have some advantages.

  • It reduces reads and writes when there is a new Reward Era and for claiming and listing unclaimed rewards. Because each chunk is a BTree, on a new Reward Era you just remove the oldest and insert the newest into each chunk.
  • It reduces reads when listing unclaimed rewards, and will reduce needed reads+writes when claim_rewards is implemented (because it will use the same function).
  • It slightly reduces the weight of a stake/unstake because the current total stake is stored separately from Reward Pool History.
  • It reduces the storage size of the reward pool history, generally, to just the total staked instead of a struct with 2 other values that aren't needed.

Checklist

  • Tests added
  • Benchmarks added
  • Weights updated
  • Migration to initialize ProviderBoostRewardPools storage and CurrentEraProviderBoostTotal
  • Verify migration works

@shannonwells shannonwells changed the base branch from main to feat/capacity-staking-rewards-impl June 5, 2024 01:21
* Cleanup for PR
* Fix broken tests
* Add storage initialization to the migration
@shannonwells shannonwells marked this pull request as ready for review June 6, 2024 23:33
@shannonwells shannonwells requested a review from wilwade as a code owner June 6, 2024 23:33
@shannonwells shannonwells marked this pull request as draft June 7, 2024 00:31
Copy link
Collaborator

@wilwade wilwade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wanting to go ahead and dump ideas. Got through most of pallets/capacity/src/lib.rs

pallets/capacity/src/lib.rs Show resolved Hide resolved
pallets/capacity/src/lib.rs Show resolved Hide resolved
pallets/capacity/src/lib.rs Show resolved Hide resolved
pallets/capacity/src/lib.rs Show resolved Hide resolved
pallets/capacity/src/lib.rs Show resolved Hide resolved
pallets/capacity/src/lib.rs Show resolved Hide resolved
pallets/capacity/src/lib.rs Show resolved Hide resolved
pallets/capacity/src/lib.rs Outdated Show resolved Hide resolved
pallets/capacity/src/lib.rs Outdated Show resolved Hide resolved
pallets/capacity/src/lib.rs Outdated Show resolved Hide resolved
Copy link
Collaborator

@wilwade wilwade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 it

@shannonwells shannonwells marked this pull request as ready for review June 10, 2024 17:35
@shannonwells shannonwells merged commit 423473f into feat/capacity-staking-rewards-impl Jun 10, 2024
@shannonwells shannonwells deleted the feat/reward-pool-refactor-#1976 branch June 10, 2024 21:30
@shannonwells shannonwells restored the feat/reward-pool-refactor-#1976 branch June 10, 2024 21:31
shannonwells added a commit that referenced this pull request Jun 12, 2024
The goal of this PR is to implement a "chunk" version of the overall
reward pool history to reduce read/write load and hence weight for
transactions and `on_initialize` when a new `RewardEra` needs to start.

Part of #1976

Co-authored-by: Wil Wade <[email protected]>
shannonwells added a commit that referenced this pull request Jun 25, 2024
The goal of this PR is to implement a "chunk" version of the overall
reward pool history to reduce read/write load and hence weight for
transactions and `on_initialize` when a new `RewardEra` needs to start.

Part of #1976

Co-authored-by: Wil Wade <[email protected]>
shannonwells added a commit that referenced this pull request Jul 18, 2024
The goal of this PR is to implement a "chunk" version of the overall
reward pool history to reduce read/write load and hence weight for
transactions and `on_initialize` when a new `RewardEra` needs to start.

Part of #1976

Co-authored-by: Wil Wade <[email protected]>
shannonwells added a commit that referenced this pull request Jul 23, 2024
The goal of this PR is to implement a "chunk" version of the overall
reward pool history to reduce read/write load and hence weight for
transactions and `on_initialize` when a new `RewardEra` needs to start.

Part of #1976

Co-authored-by: Wil Wade <[email protected]>
shannonwells added a commit that referenced this pull request Oct 9, 2024
The goal of this PR is to implement a "chunk" version of the overall
reward pool history to reduce read/write load and hence weight for
transactions and `on_initialize` when a new `RewardEra` needs to start.

Part of #1976

Co-authored-by: Wil Wade <[email protected]>
shannonwells added a commit that referenced this pull request Oct 10, 2024
updates to design docs to use a capacity rewards interface
Prototypes, make check working
refinements to design doc

Implement Staking Reward Eras basics (#1589)

Implement the basic functionality of tracking and rotating Reward Era. Closes #1567
Does not include anything to do with the Reward Pool.

Feat/staking rewards rewards provider #1572 (#1598)

The goal of this PR is to implement a really basic version of the
StakingRewardsProvider in the Capacity pallet and in the test mock,
neither of which is actively used.

Closes #1572

Does not include anything to do with setting and storing RewardPoolInfo
when each new Era starts.

change staking target extrinsic, closes #1570 (#1623)

comments, capacity boost fn added to StakingRewardsProvider trait

* Refactor staking type to go in StakingTargetDetails
* Make some functions pass by reference (performance)
* fix broken tests & calls

use capacity_boost and StakingType to adjust capacity generation, add/adjust tests

* Check from/to aren't the same when retargeting
* Performance: move non-db checks to top when retargeting
* Lots more tests
* Fix a bug where we weren't setting the staking type on a retarget
* Remove staking type from StakingAccountDetails
* Fix broken tests from last commit

Feat/reward pool history (#1710)
Closes #1710

Feat/split stake extrinsic #1699 (#1717)

The goal of this PR is to split the `stake` extrinsic into two: `stake` and `provider_boost`
Closes #1707

Feat/split storage #1726 (#1744)

The goal of this PR is to split up storage of boosting and maximized staking accounts,
as well as store retarget history separately, which can store retargeting events for
any type of staking.

Closes #1726

fix e2e tests, correction to implementation design doc

initialize storage for ProviderBoost on runtime upgrade

Set ProviderBoost capacity generated and fix tests (#1947)

* set the amount of capacity generated by a provider boost to the final amount, 50% of what is generated by MaximizedCapacity staking.
* Also Fixes some tests broken from the last rebase with main.
Closes #1569

Update reward pool on `provider_boost` or `unstake` #1699 (#1948)

The goal of this PR is to update the StakingRewardPool on a `provider_boost` or `unstake` extrinsic call.

Closes #1699

Implement rewards calculation formula #1941 (#1956)

The goal of this PR is to implement (but not really use yet) the chosen
formula for calculation of a reward in a single Provider Boost Reward
Era.

Closes #1941

updates after rebase

upsert staking history #1699 (#1963)

The goal of this PR is to add and use storage for individual staking history so that rewards can be calculated and paid out.  Benchmarks run to update capacity weights.

Relates to #1699

Chores/update capacity benchmarks #1949 (#1966)

The goal of this PR is to update the benchmark for `on_initialize` to include the weight when a new RewardEra must be created.

Closes #1949

Feat/check unclaimed rewards 1969 (#1972)

The goal of this PR is to implement `list_unclaimed_rewards`, and also
one that is lighter weight, `has_unclaimed_rewards`, which returns a
`bool` and which `unstake` extrinsic uses. Unstake now fails if there
are any unclaimed rewards.

Closes #1969
Closes #1578

Feat/reward pool refactor #1976 (#2005)

The goal of this PR is to implement a "chunk" version of the overall
reward pool history to reduce read/write load and hence weight for
transactions and `on_initialize` when a new `RewardEra` needs to start.

Part of #1976

Co-authored-by: Wil Wade <[email protected]>

Revise Provider Boost implementation design doc #2016 (#2020)

The goal of this PR is to review and update the implementation design doc in light of the chosen economic model, and to reflect some changes in behavior.  Review of the design doc also fed back into the code itself. Some code
is no longer needed.

Closes #2016

Co-authored-by: Aramik <[email protected]>

E2e for new extrinsics (#2067)

The goal of this PR is to add some e2e tests for the `provider_boost` extrinsic, and update the `change_staking_target` extrinsic after a rebase with main.

Refactor reward era (#2069)

The goal of this PR is primarily to pull RewardEra out of the Capacity Config and make it the same type everywhere.

`claim_staking_rewards` extrinsic (#2080)
Closes #1970

Capacity runtime api with list_unclaimed_rewards endpoint (#2088)
The goal of this PR is to implement a capacity runtime api for the `list_unclaimed_rewards` endpoint.
Closes #1698

Update Capacity README

address the lint failure.  updates after rebase with main

Remove TODO since it's already been addressed.
Add a minor test case to unstaking tests
Add new extrinsics to Capacity README
shannonwells added a commit that referenced this pull request Oct 18, 2024
updates to design docs to use a capacity rewards interface
Prototypes, make check working
refinements to design doc

Implement Staking Reward Eras basics (#1589)

Implement the basic functionality of tracking and rotating Reward Era. Closes #1567
Does not include anything to do with the Reward Pool.

Feat/staking rewards rewards provider #1572 (#1598)

The goal of this PR is to implement a really basic version of the
StakingRewardsProvider in the Capacity pallet and in the test mock,
neither of which is actively used.

Closes #1572

Does not include anything to do with setting and storing RewardPoolInfo
when each new Era starts.

change staking target extrinsic, closes #1570 (#1623)

comments, capacity boost fn added to StakingRewardsProvider trait

* Refactor staking type to go in StakingTargetDetails
* Make some functions pass by reference (performance)
* fix broken tests & calls

use capacity_boost and StakingType to adjust capacity generation, add/adjust tests

* Check from/to aren't the same when retargeting
* Performance: move non-db checks to top when retargeting
* Lots more tests
* Fix a bug where we weren't setting the staking type on a retarget
* Remove staking type from StakingAccountDetails
* Fix broken tests from last commit

Feat/reward pool history (#1710)
Closes #1710

Feat/split stake extrinsic #1699 (#1717)

The goal of this PR is to split the `stake` extrinsic into two: `stake` and `provider_boost`
Closes #1707

Feat/split storage #1726 (#1744)

The goal of this PR is to split up storage of boosting and maximized staking accounts,
as well as store retarget history separately, which can store retargeting events for
any type of staking.

Closes #1726

fix e2e tests, correction to implementation design doc

initialize storage for ProviderBoost on runtime upgrade

Set ProviderBoost capacity generated and fix tests (#1947)

* set the amount of capacity generated by a provider boost to the final amount, 50% of what is generated by MaximizedCapacity staking.
* Also Fixes some tests broken from the last rebase with main.
Closes #1569

Update reward pool on `provider_boost` or `unstake` #1699 (#1948)

The goal of this PR is to update the StakingRewardPool on a `provider_boost` or `unstake` extrinsic call.

Closes #1699

Implement rewards calculation formula #1941 (#1956)

The goal of this PR is to implement (but not really use yet) the chosen
formula for calculation of a reward in a single Provider Boost Reward
Era.

Closes #1941

updates after rebase

upsert staking history #1699 (#1963)

The goal of this PR is to add and use storage for individual staking history so that rewards can be calculated and paid out.  Benchmarks run to update capacity weights.

Relates to #1699

Chores/update capacity benchmarks #1949 (#1966)

The goal of this PR is to update the benchmark for `on_initialize` to include the weight when a new RewardEra must be created.

Closes #1949

Feat/check unclaimed rewards 1969 (#1972)

The goal of this PR is to implement `list_unclaimed_rewards`, and also
one that is lighter weight, `has_unclaimed_rewards`, which returns a
`bool` and which `unstake` extrinsic uses. Unstake now fails if there
are any unclaimed rewards.

Closes #1969
Closes #1578

Feat/reward pool refactor #1976 (#2005)

The goal of this PR is to implement a "chunk" version of the overall
reward pool history to reduce read/write load and hence weight for
transactions and `on_initialize` when a new `RewardEra` needs to start.

Part of #1976

Co-authored-by: Wil Wade <[email protected]>

Revise Provider Boost implementation design doc #2016 (#2020)

The goal of this PR is to review and update the implementation design doc in light of the chosen economic model, and to reflect some changes in behavior.  Review of the design doc also fed back into the code itself. Some code
is no longer needed.

Closes #2016

Co-authored-by: Aramik <[email protected]>

E2e for new extrinsics (#2067)

The goal of this PR is to add some e2e tests for the `provider_boost` extrinsic, and update the `change_staking_target` extrinsic after a rebase with main.

Refactor reward era (#2069)

The goal of this PR is primarily to pull RewardEra out of the Capacity Config and make it the same type everywhere.

`claim_staking_rewards` extrinsic (#2080)
Closes #1970

Capacity runtime api with list_unclaimed_rewards endpoint (#2088)
The goal of this PR is to implement a capacity runtime api for the `list_unclaimed_rewards` endpoint.
Closes #1698

Update Capacity README

address the lint failure.  updates after rebase with main

Remove TODO since it's already been addressed.
Add a minor test case to unstaking tests
Add new extrinsics to Capacity README
shannonwells added a commit that referenced this pull request Oct 25, 2024
updates to design docs to use a capacity rewards interface
Prototypes, make check working
refinements to design doc

Implement Staking Reward Eras basics (#1589)

Implement the basic functionality of tracking and rotating Reward Era. Closes #1567
Does not include anything to do with the Reward Pool.

Feat/staking rewards rewards provider #1572 (#1598)

The goal of this PR is to implement a really basic version of the
StakingRewardsProvider in the Capacity pallet and in the test mock,
neither of which is actively used.

Closes #1572

Does not include anything to do with setting and storing RewardPoolInfo
when each new Era starts.

change staking target extrinsic, closes #1570 (#1623)

comments, capacity boost fn added to StakingRewardsProvider trait

* Refactor staking type to go in StakingTargetDetails
* Make some functions pass by reference (performance)
* fix broken tests & calls

use capacity_boost and StakingType to adjust capacity generation, add/adjust tests

* Check from/to aren't the same when retargeting
* Performance: move non-db checks to top when retargeting
* Lots more tests
* Fix a bug where we weren't setting the staking type on a retarget
* Remove staking type from StakingAccountDetails
* Fix broken tests from last commit

Feat/reward pool history (#1710)
Closes #1710

Feat/split stake extrinsic #1699 (#1717)

The goal of this PR is to split the `stake` extrinsic into two: `stake` and `provider_boost`
Closes #1707

Feat/split storage #1726 (#1744)

The goal of this PR is to split up storage of boosting and maximized staking accounts,
as well as store retarget history separately, which can store retargeting events for
any type of staking.

Closes #1726

fix e2e tests, correction to implementation design doc

initialize storage for ProviderBoost on runtime upgrade

Set ProviderBoost capacity generated and fix tests (#1947)

* set the amount of capacity generated by a provider boost to the final amount, 50% of what is generated by MaximizedCapacity staking.
* Also Fixes some tests broken from the last rebase with main.
Closes #1569

Update reward pool on `provider_boost` or `unstake` #1699 (#1948)

The goal of this PR is to update the StakingRewardPool on a `provider_boost` or `unstake` extrinsic call.

Closes #1699

Implement rewards calculation formula #1941 (#1956)

The goal of this PR is to implement (but not really use yet) the chosen
formula for calculation of a reward in a single Provider Boost Reward
Era.

Closes #1941

updates after rebase

upsert staking history #1699 (#1963)

The goal of this PR is to add and use storage for individual staking history so that rewards can be calculated and paid out.  Benchmarks run to update capacity weights.

Relates to #1699

Chores/update capacity benchmarks #1949 (#1966)

The goal of this PR is to update the benchmark for `on_initialize` to include the weight when a new RewardEra must be created.

Closes #1949

Feat/check unclaimed rewards 1969 (#1972)

The goal of this PR is to implement `list_unclaimed_rewards`, and also
one that is lighter weight, `has_unclaimed_rewards`, which returns a
`bool` and which `unstake` extrinsic uses. Unstake now fails if there
are any unclaimed rewards.

Closes #1969
Closes #1578

Feat/reward pool refactor #1976 (#2005)

The goal of this PR is to implement a "chunk" version of the overall
reward pool history to reduce read/write load and hence weight for
transactions and `on_initialize` when a new `RewardEra` needs to start.

Part of #1976

Co-authored-by: Wil Wade <[email protected]>

Revise Provider Boost implementation design doc #2016 (#2020)

The goal of this PR is to review and update the implementation design doc in light of the chosen economic model, and to reflect some changes in behavior.  Review of the design doc also fed back into the code itself. Some code
is no longer needed.

Closes #2016

Co-authored-by: Aramik <[email protected]>

E2e for new extrinsics (#2067)

The goal of this PR is to add some e2e tests for the `provider_boost` extrinsic, and update the `change_staking_target` extrinsic after a rebase with main.

Refactor reward era (#2069)

The goal of this PR is primarily to pull RewardEra out of the Capacity Config and make it the same type everywhere.

`claim_staking_rewards` extrinsic (#2080)
Closes #1970

Capacity runtime api with list_unclaimed_rewards endpoint (#2088)
The goal of this PR is to implement a capacity runtime api for the `list_unclaimed_rewards` endpoint.
Closes #1698

Update Capacity README

address the lint failure.  updates after rebase with main

Remove TODO since it's already been addressed.
Add a minor test case to unstaking tests
Add new extrinsics to Capacity README
shannonwells added a commit that referenced this pull request Oct 29, 2024
updates to design docs to use a capacity rewards interface
Prototypes, make check working
refinements to design doc

Implement Staking Reward Eras basics (#1589)

Implement the basic functionality of tracking and rotating Reward Era. Closes #1567
Does not include anything to do with the Reward Pool.

Feat/staking rewards rewards provider #1572 (#1598)

The goal of this PR is to implement a really basic version of the
StakingRewardsProvider in the Capacity pallet and in the test mock,
neither of which is actively used.

Closes #1572

Does not include anything to do with setting and storing RewardPoolInfo
when each new Era starts.

change staking target extrinsic, closes #1570 (#1623)

comments, capacity boost fn added to StakingRewardsProvider trait

* Refactor staking type to go in StakingTargetDetails
* Make some functions pass by reference (performance)
* fix broken tests & calls

use capacity_boost and StakingType to adjust capacity generation, add/adjust tests

* Check from/to aren't the same when retargeting
* Performance: move non-db checks to top when retargeting
* Lots more tests
* Fix a bug where we weren't setting the staking type on a retarget
* Remove staking type from StakingAccountDetails
* Fix broken tests from last commit

Feat/reward pool history (#1710)
Closes #1710

Feat/split stake extrinsic #1699 (#1717)

The goal of this PR is to split the `stake` extrinsic into two: `stake` and `provider_boost`
Closes #1707

Feat/split storage #1726 (#1744)

The goal of this PR is to split up storage of boosting and maximized staking accounts,
as well as store retarget history separately, which can store retargeting events for
any type of staking.

Closes #1726

fix e2e tests, correction to implementation design doc

initialize storage for ProviderBoost on runtime upgrade

Set ProviderBoost capacity generated and fix tests (#1947)

* set the amount of capacity generated by a provider boost to the final amount, 50% of what is generated by MaximizedCapacity staking.
* Also Fixes some tests broken from the last rebase with main.
Closes #1569

Update reward pool on `provider_boost` or `unstake` #1699 (#1948)

The goal of this PR is to update the StakingRewardPool on a `provider_boost` or `unstake` extrinsic call.

Closes #1699

Implement rewards calculation formula #1941 (#1956)

The goal of this PR is to implement (but not really use yet) the chosen
formula for calculation of a reward in a single Provider Boost Reward
Era.

Closes #1941

updates after rebase

upsert staking history #1699 (#1963)

The goal of this PR is to add and use storage for individual staking history so that rewards can be calculated and paid out.  Benchmarks run to update capacity weights.

Relates to #1699

Chores/update capacity benchmarks #1949 (#1966)

The goal of this PR is to update the benchmark for `on_initialize` to include the weight when a new RewardEra must be created.

Closes #1949

Feat/check unclaimed rewards 1969 (#1972)

The goal of this PR is to implement `list_unclaimed_rewards`, and also
one that is lighter weight, `has_unclaimed_rewards`, which returns a
`bool` and which `unstake` extrinsic uses. Unstake now fails if there
are any unclaimed rewards.

Closes #1969
Closes #1578

Feat/reward pool refactor #1976 (#2005)

The goal of this PR is to implement a "chunk" version of the overall
reward pool history to reduce read/write load and hence weight for
transactions and `on_initialize` when a new `RewardEra` needs to start.

Part of #1976

Co-authored-by: Wil Wade <[email protected]>

Revise Provider Boost implementation design doc #2016 (#2020)

The goal of this PR is to review and update the implementation design doc in light of the chosen economic model, and to reflect some changes in behavior.  Review of the design doc also fed back into the code itself. Some code
is no longer needed.

Closes #2016

Co-authored-by: Aramik <[email protected]>

E2e for new extrinsics (#2067)

The goal of this PR is to add some e2e tests for the `provider_boost` extrinsic, and update the `change_staking_target` extrinsic after a rebase with main.

Refactor reward era (#2069)

The goal of this PR is primarily to pull RewardEra out of the Capacity Config and make it the same type everywhere.

`claim_staking_rewards` extrinsic (#2080)
Closes #1970

Capacity runtime api with list_unclaimed_rewards endpoint (#2088)
The goal of this PR is to implement a capacity runtime api for the `list_unclaimed_rewards` endpoint.
Closes #1698

Update Capacity README

address the lint failure.  updates after rebase with main

Remove TODO since it's already been addressed.
Add a minor test case to unstaking tests
Add new extrinsics to Capacity README
shannonwells added a commit that referenced this pull request Oct 30, 2024
updates to design docs to use a capacity rewards interface
Prototypes, make check working
refinements to design doc

Implement Staking Reward Eras basics (#1589)

Implement the basic functionality of tracking and rotating Reward Era. Closes #1567
Does not include anything to do with the Reward Pool.

Feat/staking rewards rewards provider #1572 (#1598)

The goal of this PR is to implement a really basic version of the
StakingRewardsProvider in the Capacity pallet and in the test mock,
neither of which is actively used.

Closes #1572

Does not include anything to do with setting and storing RewardPoolInfo
when each new Era starts.

change staking target extrinsic, closes #1570 (#1623)

comments, capacity boost fn added to StakingRewardsProvider trait

* Refactor staking type to go in StakingTargetDetails
* Make some functions pass by reference (performance)
* fix broken tests & calls

use capacity_boost and StakingType to adjust capacity generation, add/adjust tests

* Check from/to aren't the same when retargeting
* Performance: move non-db checks to top when retargeting
* Lots more tests
* Fix a bug where we weren't setting the staking type on a retarget
* Remove staking type from StakingAccountDetails
* Fix broken tests from last commit

Feat/reward pool history (#1710)
Closes #1710

Feat/split stake extrinsic #1699 (#1717)

The goal of this PR is to split the `stake` extrinsic into two: `stake` and `provider_boost`
Closes #1707

Feat/split storage #1726 (#1744)

The goal of this PR is to split up storage of boosting and maximized staking accounts,
as well as store retarget history separately, which can store retargeting events for
any type of staking.

Closes #1726

fix e2e tests, correction to implementation design doc

initialize storage for ProviderBoost on runtime upgrade

Set ProviderBoost capacity generated and fix tests (#1947)

* set the amount of capacity generated by a provider boost to the final amount, 50% of what is generated by MaximizedCapacity staking.
* Also Fixes some tests broken from the last rebase with main.
Closes #1569

Update reward pool on `provider_boost` or `unstake` #1699 (#1948)

The goal of this PR is to update the StakingRewardPool on a `provider_boost` or `unstake` extrinsic call.

Closes #1699

Implement rewards calculation formula #1941 (#1956)

The goal of this PR is to implement (but not really use yet) the chosen
formula for calculation of a reward in a single Provider Boost Reward
Era.

Closes #1941

updates after rebase

upsert staking history #1699 (#1963)

The goal of this PR is to add and use storage for individual staking history so that rewards can be calculated and paid out.  Benchmarks run to update capacity weights.

Relates to #1699

Chores/update capacity benchmarks #1949 (#1966)

The goal of this PR is to update the benchmark for `on_initialize` to include the weight when a new RewardEra must be created.

Closes #1949

Feat/check unclaimed rewards 1969 (#1972)

The goal of this PR is to implement `list_unclaimed_rewards`, and also
one that is lighter weight, `has_unclaimed_rewards`, which returns a
`bool` and which `unstake` extrinsic uses. Unstake now fails if there
are any unclaimed rewards.

Closes #1969
Closes #1578

Feat/reward pool refactor #1976 (#2005)

The goal of this PR is to implement a "chunk" version of the overall
reward pool history to reduce read/write load and hence weight for
transactions and `on_initialize` when a new `RewardEra` needs to start.

Part of #1976

Co-authored-by: Wil Wade <[email protected]>

Revise Provider Boost implementation design doc #2016 (#2020)

The goal of this PR is to review and update the implementation design doc in light of the chosen economic model, and to reflect some changes in behavior.  Review of the design doc also fed back into the code itself. Some code
is no longer needed.

Closes #2016

Co-authored-by: Aramik <[email protected]>

E2e for new extrinsics (#2067)

The goal of this PR is to add some e2e tests for the `provider_boost` extrinsic, and update the `change_staking_target` extrinsic after a rebase with main.

Refactor reward era (#2069)

The goal of this PR is primarily to pull RewardEra out of the Capacity Config and make it the same type everywhere.

`claim_staking_rewards` extrinsic (#2080)
Closes #1970

Capacity runtime api with list_unclaimed_rewards endpoint (#2088)
The goal of this PR is to implement a capacity runtime api for the `list_unclaimed_rewards` endpoint.
Closes #1698

Update Capacity README

address the lint failure.  updates after rebase with main

Remove TODO since it's already been addressed.
Add a minor test case to unstaking tests
Add new extrinsics to Capacity README
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants