Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(upgrade): v1.7.2 to v1.8.0 #2081

Merged
merged 1 commit into from
Jul 23, 2024
Merged

chore(upgrade): v1.7.2 to v1.8.0 #2081

merged 1 commit into from
Jul 23, 2024

Conversation

enddynayn
Copy link
Collaborator

@enddynayn enddynayn commented Jul 16, 2024 •
edited
Loading

For more details, please refer to:

Release Notes

#1894

@enddynayn enddynayn force-pushed the chore/upgrade-polkadot-v1.7.2-to-v1.8.0-issue-1894 branch 9 times, most recently from b1d4dc6 to 040b25c Compare July 18, 2024 21:41
@codecov Codecov
Copy link

codecov bot commented Jul 18, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Files Coverage Δ
pallets/msa/src/lib.rs 88.07% <ø> (ø)

@github-actions github-actions bot added metadata-changed Metadata has changed since the latest full release metadata-version-not-incremented Metadata has changed since the latest full release, but the version has not been incremented and removed metadata-changed Metadata has changed since the latest full release metadata-version-not-incremented Metadata has changed since the latest full release, but the version has not been incremented labels Jul 18, 2024
@enddynayn enddynayn force-pushed the chore/upgrade-polkadot-v1.7.2-to-v1.8.0-issue-1894 branch 2 times, most recently from 6e01ff4 to ecbc195 Compare July 19, 2024 15:04
@github-actions github-actions bot added metadata-changed Metadata has changed since the latest full release and removed metadata-changed Metadata has changed since the latest full release labels Jul 19, 2024
@enddynayn enddynayn force-pushed the chore/upgrade-polkadot-v1.7.2-to-v1.8.0-issue-1894 branch from ecbc195 to dc328b1 Compare July 22, 2024 15:17
@github-actions github-actions bot removed the metadata-changed Metadata has changed since the latest full release label Jul 22, 2024
@enddynayn enddynayn force-pushed the chore/upgrade-polkadot-v1.7.2-to-v1.8.0-issue-1894 branch 2 times, most recently from 1a944cb to 4d445bd Compare July 22, 2024 15:20
@github-actions github-actions bot added the metadata-changed Metadata has changed since the latest full release label Jul 22, 2024
@enddynayn enddynayn force-pushed the chore/upgrade-polkadot-v1.7.2-to-v1.8.0-issue-1894 branch from 3967d0a to cb49362 Compare July 22, 2024 16:46
@github-actions github-actions bot removed the metadata-changed Metadata has changed since the latest full release label Jul 22, 2024
@enddynayn enddynayn force-pushed the chore/upgrade-polkadot-v1.7.2-to-v1.8.0-issue-1894 branch from cb49362 to 19b0223 Compare July 22, 2024 16:47
@enddynayn enddynayn marked this pull request as ready for review July 22, 2024 16:47
@enddynayn enddynayn requested review from demisx and wilwade as code owners July 22, 2024 16:47
@enddynayn enddynayn force-pushed the chore/upgrade-polkadot-v1.7.2-to-v1.8.0-issue-1894 branch from 19b0223 to 6d6228b Compare July 22, 2024 16:57
@github-actions github-actions bot added metadata-changed Metadata has changed since the latest full release and removed metadata-changed Metadata has changed since the latest full release labels Jul 22, 2024
@enddynayn enddynayn force-pushed the chore/upgrade-polkadot-v1.7.2-to-v1.8.0-issue-1894 branch 2 times, most recently from b7f7acf to 1687730 Compare July 22, 2024 20:52
saraswatpuneet
saraswatpuneet approved these changes Jul 22, 2024
View reviewed changes
Copy link
Collaborator

@saraswatpuneet saraswatpuneet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@github-actions github-actions bot added metadata-changed Metadata has changed since the latest full release and removed metadata-changed Metadata has changed since the latest full release labels Jul 22, 2024
@enddynayn enddynayn force-pushed the chore/upgrade-polkadot-v1.7.2-to-v1.8.0-issue-1894 branch from afd06b4 to 92cf712 Compare July 23, 2024 12:46
@github-actions github-actions bot added metadata-changed Metadata has changed since the latest full release and removed metadata-changed Metadata has changed since the latest full release labels Jul 23, 2024
JoeCap08055
JoeCap08055 approved these changes Jul 23, 2024
View reviewed changes
Copy link
Collaborator

@JoeCap08055 JoeCap08055 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, no logic changes, mostly weights & build/cargo stuff

@enddynayn enddynayn force-pushed the chore/upgrade-polkadot-v1.7.2-to-v1.8.0-issue-1894 branch from 8baf97f to b0534f9 Compare July 23, 2024 15:28
@github-actions github-actions bot removed the metadata-changed Metadata has changed since the latest full release label Jul 23, 2024
@enddynayn
chore(upgrade): v1.7.2 to v1.8.0
f7b60a8 
For more details, please refer to:

[Release Notes](https://github.com/paritytech/polkadot-sdk/releases/tag/polkadot-v1.8.0)

Update weights.

issue-1894
@enddynayn enddynayn force-pushed the chore/upgrade-polkadot-v1.7.2-to-v1.8.0-issue-1894 branch from b0534f9 to f7b60a8 Compare July 23, 2024 15:28
@github-actions github-actions bot added the metadata-changed Metadata has changed since the latest full release label Jul 23, 2024
claireolmstead
claireolmstead reviewed Jul 23, 2024
View reviewed changes
runtime/frequency/Cargo.toml
@@ -12,7 +12,7 @@ version = "0.0.0"
targets = ["x86_64-unknown-linux-gnu"]

[build-dependencies]
substrate-wasm-builder = { version = "5.0.0-dev", git = "https://github.com/paritytech/polkadot-sdk", branch = "release-polkadot-v1.3.0"}
substrate-wasm-builder = { git = "https://github.com/paritytech/polkadot-sdk", branch = "release-polkadot-v1.8.0"}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it auto-set the version? why are we removing?

Copy link
Collaborator Author

@enddynayn enddynayn Jul 23, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question. If you’re using a specific branch from a Git repository, you can omit the version. However, including it doesn’t cause any issues. I’ll be creating a separate PR to switch to using crates instead of Git branches.

claireolmstead
claireolmstead approved these changes Jul 23, 2024
View reviewed changes
Copy link
Collaborator

@claireolmstead claireolmstead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lot's of weight changes! LGTM!

aramikm
aramikm approved these changes Jul 23, 2024
View reviewed changes
Copy link
Collaborator

@aramikm aramikm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just one question!

node/cli/Cargo.toml
@@ -77,12 +77,14 @@ default = ["std", "cli"]
runtime-benchmarks = [
"polkadot-cli/runtime-benchmarks",
"frequency-runtime/runtime-benchmarks",
"sc-service?/runtime-benchmarks",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Q: why this has ? ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that it was configured that way in substrate. I have made a note of it to see if we can remove it on my follow up PR.

shannonwells
shannonwells approved these changes Jul 23, 2024
View reviewed changes
Copy link
Collaborator

@shannonwells shannonwells left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works on my machine!

@enddynayn enddynayn merged commit 2676db8 into main Jul 23, 2024
27 checks passed
@enddynayn enddynayn deleted the chore/upgrade-polkadot-v1.7.2-to-v1.8.0-issue-1894 branch July 23, 2024 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saraswatpuneet saraswatpuneet saraswatpuneet approved these changes

@JoeCap08055 JoeCap08055 JoeCap08055 approved these changes

@claireolmstead claireolmstead claireolmstead approved these changes

@aramikm aramikm aramikm approved these changes

@shannonwells shannonwells shannonwells approved these changes

@wilwade wilwade Awaiting requested review from wilwade wilwade is a code owner

@mattheworris mattheworris Awaiting requested review from mattheworris

Assignees
No one assigned
Labels
metadata-changed Metadata has changed since the latest full release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@enddynayn @shannonwells @aramikm @claireolmstead @saraswatpuneet @JoeCap08055