Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize rust docs args and use of RUSTC_BOOTSTRAP #2120

Merged
merged 1 commit into from
Aug 12, 2024

Conversation

wilwade
Copy link
Collaborator

@wilwade wilwade commented Aug 12, 2024

Goal

The goal of this PR is to fix an issue with the last RC release attempt: https://github.com/frequency-chain/frequency/actions/runs/10324779461

Discussion

  • RUSTC_BOOTSTRAP turns "stable" rust into "nightly"
  • We were using this before in places, but not consistently across all the workflows
  • This correctly updates everything to use it and all to use the consistent parameters

Verify

Locally run the make docs or RUSTC_BOOTSTRAP=1 RUSTDOCFLAGS="--enable-index-page -Zunstable-options" cargo doc --no-deps --workspace --features frequency command

@wilwade wilwade requested review from a team, shannonwells and mattheworris and removed request for a team August 12, 2024 14:35
@wilwade wilwade requested a review from demisx as a code owner August 12, 2024 14:35
@wilwade wilwade enabled auto-merge (squash) August 12, 2024 14:35
Copy link
Collaborator

@claireolmstead claireolmstead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@enddynayn enddynayn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 nice!

@wilwade wilwade merged commit 29a85e3 into main Aug 12, 2024
25 checks passed
@wilwade wilwade deleted the chore/use-rustc-boostrap-for-docs branch August 12, 2024 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants