Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature Passkey Proxy v2, Simple Param Shift #2242

Merged
merged 4 commits into from
Dec 16, 2024
Merged

Feature Passkey Proxy v2, Simple Param Shift #2242

merged 4 commits into from
Dec 16, 2024

Conversation

wilwade
Copy link
Collaborator

@wilwade wilwade commented Dec 13, 2024 •
edited
Loading

Goal

The goal of this PR is to shift the accountOwnershipProof out of the signature payload. For reasons why, see #2241

Closes #2241

With @aramikm

Discussion

  • Added proxy_v2
  • Deprecated proxy
  • Duplicated tests, as eventually we'll remove v1

Checklist

  • Updated Pallet Readme?
  • Unit Tests added?
  • e2e Tests added?
  • Benchmarks added?
  • Spec version incremented?

@wilwade wilwade requested a review from aramikm December 13, 2024 16:09
@codecov Codecov
Copy link

codecov bot commented Dec 13, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 96.82081% with 11 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
pallets/passkey/src/types.rs 72.50% 11 Missing ⚠️
Files with missing lines Coverage Δ
pallets/passkey/src/lib.rs 96.85% <100.00%> (+0.19%) ⬆️
pallets/passkey/src/tests_v2.rs 100.00% <100.00%> (ø)
pallets/passkey/src/types.rs 69.10% <72.50%> (+1.63%) ⬆️

@github-actions github-actions bot added the metadata-changed Metadata has changed since the latest full release label Dec 13, 2024
@aramikm
Feature/passkey proxy param shift 2241 2 (#2243)
6e3611d 
# Goal
The goal of this PR is <!-- insert goal here -->

Closes <!-- issue # -->

# Discussion

- <!-- List discussion items -->

# Checklist
- [ ] Updated Pallet Readme?
- [ ] Updated js/api-augment for Custom RPC APIs?
- [ ] Design doc(s) updated?
- [ ] Unit Tests added?
- [ ] e2e Tests added?
- [ ] Benchmarks added?
- [ ] Spec version incremented?
@github-actions github-actions bot added metadata-changed Metadata has changed since the latest full release and removed metadata-changed Metadata has changed since the latest full release labels Dec 13, 2024
@wilwade wilwade marked this pull request as ready for review December 14, 2024 00:00
@wilwade wilwade requested a review from a team December 14, 2024 00:01
aramikm
aramikm approved these changes Dec 14, 2024
View reviewed changes
Copy link
Collaborator

@aramikm aramikm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@wilwade wilwade enabled auto-merge (squash) December 14, 2024 21:35
saraswatpuneet
saraswatpuneet approved these changes Dec 16, 2024
View reviewed changes
Copy link
Collaborator

@saraswatpuneet saraswatpuneet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would we need to update the iframe ? Or it's not being used

@wilwade wilwade merged commit 2f40169 into main Dec 16, 2024
30 checks passed
@wilwade wilwade deleted the feature/passkey-proxy-param-shift-2241 branch December 16, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoeCap08055 JoeCap08055 JoeCap08055 approved these changes

@saraswatpuneet saraswatpuneet saraswatpuneet approved these changes

@aramikm aramikm aramikm approved these changes

Assignees
No one assigned
Labels
metadata-changed Metadata has changed since the latest full release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature: Passkey Proxy shift accountOwnershipProof parameter
4 participants
@wilwade @aramikm @saraswatpuneet @JoeCap08055