Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Release Metadata Comparison #2250

Merged
merged 8 commits into from
Jan 6, 2025
Merged

Fix Release Metadata Comparison #2250

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
0e94b12
Fix missng env var and update to use local instead of dev to correctl…
wilwade Jan 6, 2025
98f9722
Fix test binary name
wilwade Jan 6, 2025
e0266bc
Fix test binary folder
wilwade Jan 6, 2025
b1dcb41
Fix chain reference
wilwade Jan 6, 2025
c45eb78
Switch from local to dev
wilwade Jan 6, 2025
a7ced44
REVERT ME: Test against v1.15.0 tag
wilwade Jan 6, 2025
85beba3
Revert "Switch from local to dev"
wilwade Jan 6, 2025
000711c
Revert "REVERT ME: Test against v1.15.0 tag"
wilwade Jan 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -513,8 +513,8 @@ jobs:
runs-on: ubuntu-22.04
env:
BIN_DIR: target/release
BIN_FILENAME: frequency-dev.amd64
TEST_BIN_FILENAME: frequency-dev.amd64
BIN_FILENAME: frequency-local.amd64
TEST_BIN_FILENAME: frequency-local.amd64
TEST_DOWNLOAD_DIR: download-test
REF_BIN_FILENAME: frequency-ref.amd64
REF_DOWNLOAD_DIR: download-ref
Expand Down Expand Up @@ -544,7 +544,7 @@ jobs:
id: download-binaries
uses: actions/download-artifact@v4
with:
pattern: artifacts-binary-${{env.NETWORK}}-${{github.run_id}}
pattern: artifacts-binary-local-${{github.run_id}}
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was the main fix, but also swapped from dev to local so that we could also tag any parachain related pallet changes.

path: ${{env.TEST_DOWNLOAD_DIR}}
- name: Rename and Move Binaries
run: |
Expand All @@ -554,12 +554,14 @@ jobs:
echo "Downloaded binaries: $(ls -l $download_dir)"
mkdir -p ${{env.BIN_DIR}}
mv ${{env.REF_DOWNLOAD_DIR}}/${{env.BIN_FILENAME}} ${{env.BIN_DIR}}/${{env.REF_BIN_FILENAME}}
mv ${{env.TEST_DOWNLOAD_DIR}}/${{env.BIN_FILENAME}} ${{env.BIN_DIR}}/${{env.TEST_BIN_FILENAME}}
mv "${download_dir}/${{env.BIN_FILENAME}}" ${{env.BIN_DIR}}/${{env.TEST_BIN_FILENAME}}
- name: Set Binary Permissions
working-directory: ${{env.BIN_DIR}}
run: |
chmod 755 $TEST_BIN_FILENAME
chmod 755 $REF_BIN_FILENAME
echo "Binary Directory:"
ls -la ./
- name: Docker network
run: docker network create net-${{env.RELEASE_BRANCH_NAME}}
- name: Start Test Node
Expand All @@ -570,7 +572,6 @@ jobs:
--name test-node \
ubuntu:24.04 \
/bin/sh -c "chmod +x /app/${{env.TEST_BIN_FILENAME}} && /app/${{env.TEST_BIN_FILENAME}} \
--chain=dev \
wilwade marked this conversation as resolved.
Show resolved Hide resolved
--rpc-external \
--rpc-cors=all \
--rpc-methods=Unsafe \
Expand All @@ -590,7 +591,6 @@ jobs:
--name ref-node \
ubuntu:24.04 \
/bin/sh -c "chmod +x /app/${{env.REF_BIN_FILENAME}} && /app/${{env.REF_BIN_FILENAME}} \
--chain=dev \
--rpc-external \
--rpc-cors=all \
--rpc-methods=Unsafe \
Expand Down
Loading