Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

split apart get api function #142

Merged
merged 5 commits into from
Feb 8, 2024
Merged

split apart get api function #142

merged 5 commits into from
Feb 8, 2024

Conversation

claireolmstead
Copy link
Contributor

@claireolmstead claireolmstead commented Feb 6, 2024 •
edited
Loading

closes #140
blocked by #139 (only affects Provider and Capacity components)

@claireolmstead claireolmstead self-assigned this Feb 6, 2024
@claireolmstead claireolmstead marked this pull request as ready for review February 6, 2024 05:27
rlaferla
rlaferla reviewed Feb 6, 2024
View reviewed changes
Copy link
Contributor

@rlaferla rlaferla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Provider and Capacity blocks show "Not Connected"

Screen.Recording.2024-02-06.at.9.05.45.AM.mov

wilwade
wilwade reviewed Feb 6, 2024
View reviewed changes
src/lib/polkadotApi.ts Outdated Show resolved Hide resolved
@claireolmstead
Copy link
Contributor Author

claireolmstead commented Feb 6, 2024 •
edited
Loading

Provider and Capacity blocks show "Not Connected"

Screen.Recording.2024-02-06.at.9.05.45.AM.mov

@rlaferla, In the top comment I say "blocked by #139 (only affects Provider and Capacity components)". #139 will be merged in first and this will not happen.

@claireolmstead claireolmstead force-pushed the 140-split-apart-getapi branch 2 times, most recently from 55aefe6 to 88e5978 Compare February 6, 2024 18:02
mattheworris
mattheworris approved these changes Feb 7, 2024
View reviewed changes
Copy link
Contributor

@mattheworris mattheworris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 it!

  • Read through the code changes.
  • Executed the app and clicked through some test cases.

@claireolmstead claireolmstead merged commit b780969 into main Feb 8, 2024
3 checks passed
@claireolmstead claireolmstead deleted the 140-split-apart-getapi branch February 8, 2024 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rlaferla rlaferla rlaferla left review comments

@mattheworris mattheworris mattheworris approved these changes

@shannonwells shannonwells Awaiting requested review from shannonwells

@enddynayn enddynayn Awaiting requested review from enddynayn

@wilwade wilwade Awaiting requested review from wilwade

Assignees

@claireolmstead claireolmstead

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

split apart getApi()
5 participants
@claireolmstead @rlaferla @wilwade @mattheworris @enddynayn