Styling and UX improvements. #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* text colors * @apply for button types * class overrides for KeySelection * Actions are now "cards" that use the class overrides * remove old styles in components for unified look * fix bug in AddControlKey * de-linting
shannonwells
commented
Aug 14, 2023
| <div class="pl-6 ml-6 border-l-8 border-aqua"> | ||
| <h3 class="text-aqua font-bold">Capacity</h3> | ||
| {#if !connected} | ||
| <p>Not connected</p> |
There was a problem hiding this comment.
All the "status" items at the top now display more or less the same information until you are connected and we know if you are a Provider or you just have an MSA.
shannonwells
commented
Aug 14, 2023
| @@ -81,7 +78,7 @@ | |||
| if (isFunction(thisWeb3FromSource) && isFunction(thisWeb3Enable)) { | |||
| const extensions = await thisWeb3Enable('Frequency parachain provider dashboard: Adding Keys'); | |||
| if (extensions.length !== 0) { | |||
| const injectedExtension = await thisWeb3FromSource(signingKeys.meta.source); | |||
| const injectedExtension = await thisWeb3FromSource(signingKeys.meta.source.toString()); | |||
There was a problem hiding this comment.
because typescript
shannonwells
commented
Aug 14, 2023
| }; | ||
| </script> | ||
|
|
||
| <svelte:head> | ||
| <link rel="stylesheet" href="https://unpkg.com/[email protected]/mvp.css" /> |
shannonwells
commented
Aug 14, 2023
| <link rel="stylesheet" href="https://unpkg.com/[email protected]/mvp.css" /> | ||
| </svelte:head> | ||
|
|
||
| <h1>Welcome to Provider Dashboard</h1> |
There was a problem hiding this comment.
still need a good title though.
| it('is hidden', () => { | ||
| const { container } = render(Capacity, { token: 'FLARP' }); | ||
| expect(container.querySelector('div div')).toHaveClass('hidden'); | ||
| it('is says it is not connected', () => { |
There was a problem hiding this comment.
Suggested change
| it('is says it is not connected', () => { | |
| it('it says it is not connected', () => { |
mattheworris
approved these changes
Aug 15, 2023
|
One other thing: on Rococo, my test account has 5,009.7716 XRQCY, but Provider Dashboard shows it as 50.0977. I didn't get a chance to dig in and find where that happens in the code. |
wilwade
reviewed
Aug 15, 2023
src/lib/utils.ts
Outdated
| }; | ||
|
|
||
| export const balanceToHuman = (balance: bigint, token: string): string => { | ||
| return formatBalance(balance, { withSiFull: true, withUnit: token, withZero: true, decimals: 10 }); |
There was a problem hiding this comment.
Suggested change
| return formatBalance(balance, { withSiFull: true, withUnit: token, withZero: true, decimals: 10 }); | |
| return formatBalance(balance, { withSiFull: true, withUnit: token, withZero: true, decimals: 8 }); |
wilwade
reviewed
Aug 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Styling and UX improvements
References #41
Details
I'd like to get this in to main before it goes any further since this was supposed to be "basic" styling and it's kind of a lot.