Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alternative version of python-ly conversion #138

Open
wants to merge 222 commits into
base: master
Choose a base branch
from

Conversation

bryantgeorge
Copy link

This encompasses half a year's worth of work on the lilypond to musicxml conversion script. It drastically changes how the conversion works and was branched off of v0.9.5, so I don't exactly expect it to be merged into master, but I hope my fork's stable branch can serve as an alternative version of sorts in case master doesn't fit the needs of anyone.

Intended features include:

  • Lyrics with structures like \lyricsto Voice \new Lyrics \Stanza
  • Chord symbols
  • Beaming (explicit and automatic)
  • Smart bar line placement
  • Somewhat smart lyric placement
  • Accidentals
  • And more...

Do with this as you will.

Add stanzas to first voice

See merge request bgeorge/python-ly!1
Resolve "Fix tests"

See merge request bgeorge/python-ly!2
Resolve "Lyric Placement: fix issues"

See merge request bgeorge/python-ly!6
Resolve "Measure Barlines: Use special barlines to mark phrase breaks."

See merge request bgeorge/python-ly!5
Resolve "Fix Pickup Measure notes timing"

See merge request bgeorge/python-ly!3
…o 'stable'

Resolve "Last measures and last note lengths inconsistent"

See merge request bgeorge/python-ly!8
This is because I merged into 9 instead of stable
Resolve "Fix bug caused by empty alto part"

Closes frescobaldi#44

See merge request bgeorge/python-ly!51
Resolve "Support subtitles"

Closes frescobaldi#46

See merge request bgeorge/python-ly!53
Resolve "Support multiple lyrics on same note"

Closes frescobaldi#43

See merge request bgeorge/python-ly!50
Resolve "Support breath marks"

Closes frescobaldi#45

See merge request bgeorge/python-ly!52
Resolve "Support manual measure length set"

Closes frescobaldi#42

See merge request bgeorge/python-ly!55
Resolve "Handle ties from chords"

Closes frescobaldi#47

See merge request bgeorge/python-ly!54
Resolve "Support italic lyrics"

Closes frescobaldi#49

See merge request bgeorge/python-ly!57
# Conflicts:
#   ly/musicxml/lymus2musxml.py
Resolve "Fix lyric error reporting bug"

Closes frescobaldi#50

See merge request bgeorge/python-ly!58
@wbsoft
Copy link
Collaborator

wbsoft commented Jan 6, 2020

Wow, this is very nice! Thanks! My first estimation is that this really needs to be incorporated into "official" python-ly. Will look further into it the coming days!

@wbsoft
Copy link
Collaborator

wbsoft commented Jan 6, 2020

@PeterBjuhr maybe you can also have a look with me? You wrote most of the musicxml stuff IIRC. Some changes are easy to resolve, but others need a bit more know-how.

@PeterBjuhr
Copy link
Collaborator

I totally agree! I'll take a look!

@PeterBjuhr
Copy link
Collaborator

I'm sorry! I've taken a good look at this, but I haven't worked with it for a while and I don't think I can resolve everything! @Syobnaf can you take a look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants