Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added changelog-enforcer to pull request workflow #19

Merged
merged 1 commit into from
May 24, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion .github/workflows/pull-request-checks.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,12 @@
name: Pull request checks

on: [ pull_request ]
on:
pull_request:
# The specific activity types are listed here to include "labeled" and "unlabeled"
# (which are not included by default for the "pull_request" trigger).
# This is needed to allow skipping enforcement of the changelog in PRs with specific labels,
# as defined in the (optional) "skipLabels" property.
types: [ opened, synchronize, reopened, ready_for_review, labeled, unlabeled ]

jobs:
tests:
Expand Down Expand Up @@ -37,7 +43,11 @@ jobs:

- name: Run lint PHP
run: composer run-script php-cs-fixer-dry-run
if: success() || failure()

# Tests
- name: Run PHP unit test suite
run: vendor/bin/phpunit -v -c .

- uses: dangoslen/changelog-enforcer@v3
if: success() || failure()
45 changes: 34 additions & 11 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,14 +1,37 @@
CHANGELOG
=========
# Changelog

This changelog references the relevant changes (bug/security fixes, enhancements) done in minor versions.
To get the diff between two versions, go to: https://github.com/freshheads/FHMultiSiteBundle/compare/v1.0.0...v1.0.1
All notable changes to this project will be documented in this file.

1.1
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

* Drops support for Symfony below version 4.4
* Adds support for Symfony 5.x
* Adds support for Twig 3
* Marks bundle config classes as final in docblock; will be final in next major:
* FH\Bundle\MultiSiteBundle\DependencyInjection\Configuration
* FH\Bundle\MultiSiteBundle\DependencyInjection\FHMultiSiteExtension
## Unreleased

### Added

- Added `changelog-enforcer` to pull request workflow.

### Changed

- Run pull request workflow also on lowest dependencies.
- Added `php-cs-fixer/shim` as dev dependency.

### Removed

- Removed support for PHP 7.3.
- Removed `bamarni/composer-bin-plugin` dev dependency.

## 1.1.0 - 2020-07-08

### Added

- Added support for Symfony 5.x.
- Added support for Twig 3.

### Removed

- Dropped support for Symfony below version 4.4.

### Deprecated

- Marked classes in `FH\Bundle\MultiSiteBundle\DependencyInjection` as final in docblock; will be final in next major.