implement _write() #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even if
_writev()is implemented, it appears that_write()is not optional:https://nodejs.org/api/stream.html#stream_writable_write_chunk_encoding_callback_1
nodejs/node#28408 (comment)
I ran into this when testing
@frida/web-clientin the browser, compiled with rollup. I did need to usevite-compatible-readable-streaminstead ofreadable-streamdue to rollup circular dependency issues: nodejs/readable-stream#348 (comment). At runtime I was getting errors about_write.This commit implements
_write()in terms of_writev(). I think this is appropriate, and is very simple to implement this way.