Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic ShipEngine LTL service class #172

Merged
merged 2 commits into from
Jul 19, 2023
Merged

Basic ShipEngine LTL service class #172

merged 2 commits into from
Jul 19, 2023

Conversation

pelargir
Copy link
Collaborator

This implements a basic ShipEngine LTL service class with API endpoints to create, update, and list carriers.

@pelargir pelargir requested review from tvdeyen and mamhoff July 17, 2023 18:28
@pelargir pelargir force-pushed the ship-engine-ltl branch 2 times, most recently from fa3e4a3 to 6ba3ed0 Compare July 18, 2023 19:02
spec/spec_helper.rb Outdated Show resolved Hide resolved
Copy link
Contributor

@mamhoff mamhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@pelargir
Copy link
Collaborator Author

Specs are still failing in CircleCI. It's as if dotenv is not being loaded.

This implements a basic service class for ShipEngine LTL. The initial
API endpoints available are:

- List carriers
- Connect carrier
- Update carrier
@pelargir
Copy link
Collaborator Author

Got it fixed. Sure enough, .env.test wasn't being loaded.

@pelargir pelargir merged commit 817a9e6 into main Jul 19, 2023
@pelargir pelargir deleted the ship-engine-ltl branch July 19, 2023 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants