Add hook to selection #47
Conversation
|
@mankowitz good idea. I guess a corresponding deleteMatch: {
type: Function,
default: (name, chunk, suffix) => {
return chunk === name + suffix
}
}, |
|
@fritx - Can you merge the processItem into the next build? |
|
@mankowitz sorry.. but have a look at my previous comments :D The changes seem to be more than just one feature, I want things to be nailed in certain commits. And also, I would switch to |
| @@ -18,7 +18,7 @@ | |||
|
|
|||
| <at-ta :members="members" name-key="name" v-model="text"> | |||
| <!-- custom: with avatars --> | |||
| <template slot="item" scope="s"> | |||
| <template slot="item" slot-scope="s"> | |||
There was a problem hiding this comment.
Agreed to use slot-scope as a Vue upgrade, 👍
but I've been afraid it would break users that were still using older versions of Vue.
So I'd like to make such changes later in a major bump 😄
| @@ -20,6 +20,7 @@ | |||
| :class="isCur(index) && 'atwho-cur'" | |||
| :ref="isCur(index) && 'cur'" | |||
| :data-index="index" | |||
| :key="index" | |||
| processItem: { | ||
| type: Function, | ||
| default: (list, cur, suffix) => { | ||
| return itemName(list[cur]) + suffix |
There was a problem hiding this comment.
I'm afriad the itemName here would be "not defined" 😨
There was a problem hiding this comment.
It shouldn’t be undefind. I was able to use it. Maybe add a check first?
There was a problem hiding this comment.
@mankowitz it should be not defined 'cause itemName is defined in methods not in top-level scope.
|
@mankowitz i'm sorry you have deleted the source of this PR and |
I added an overwritable function called
processItemthat allows the user to process the mention before inserting it in the element