Issue doip#48: StandardGateway.onConnectionClosed: removeListener was…

… missing
froks-contrib · Mar 24, 2020 · 3971434 · 3971434
1 parent 88bdee0
commit 3971434
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/RELEASE-NOTES.txt b/RELEASE-NOTES.txt
@@ -24,6 +24,11 @@ http://automotive-doip.com/downloads/DoIP-Software-Documentation.pdf
 
                      Release Notes for Version: 1.4.3
 
+FIXED BUGS
+==========
+
+- Issue #48:   StandardGateway.onConnectionClosed: removeListener was missing
+
 NEW FEATURES
 ============
 
@@ -36,7 +41,7 @@ NEW FEATURES
                      Release Notes for Version: 1.4.2
 
 FIXED BUGS
-==========:
+==========
 
 - Issue #39:   Made method StandardEcu.clearCurrentRequest() public.
                (also setter & getter made public)

diff --git a/src/main/java/doip/simulation/standard/StandardGateway.java b/src/main/java/doip/simulation/standard/StandardGateway.java
@@ -165,6 +165,7 @@ public void onConnectionAccepted(TcpServer tcpServer, Socket socket) {
 	@Override
 	public void onConnectionClosed(DoipTcpConnection doipTcpConnection) {
 		logger.trace(">>> public void onConnectionClosed(DoipTcpConnection doipTcpConnection)");
+		doipTcpConnection.removeListener(this);
 		this.standardConnectionList.remove(doipTcpConnection);
 		logger.trace("<<< public void onConnectionClosed(DoipTcpConnection doipTcpConnection)");
 	}