Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full switch to poetry #600

Merged
merged 14 commits into from
Nov 1, 2022
Merged

Full switch to poetry #600

merged 14 commits into from
Nov 1, 2022

Conversation

carmenbianca
Copy link
Member

@carmenbianca carmenbianca commented Oct 7, 2022

Accidentally closed #599 due to wrong branch name.

Fixes #467, fixes #289, fixes #587

I was doing some package maintenance for Fedora. This should make my life a whole lot easier.

Maybe postpone this for 2.0 major release. No longer a breaking change. Python 3.6 remains supported.

TODO:

  • Translation build step.
  • Don't install dev requirements in Docker images and reuse GitHub workflow
  • Fix Docker containers
  • Fix documentation
  • Change log
  • Write message to reuse mailing list
  • Test poetry publishing
    • Signed releases?
  • Fix python-debian dependency
    • Ideally, ship with dep5 parser microlibrary.
  • Replicate and document make test / make lint.
  • Fix pylint pre-commit.
  • Remove requests dependency now that we're messing with dependencies anyway.

@carmenbianca carmenbianca force-pushed the poetry branch 5 times, most recently from be17163 to fd90227 Compare October 7, 2022 22:42
@carmenbianca carmenbianca requested a review from linozen October 7, 2022 23:09
@carmenbianca
Copy link
Member Author

This is effectively ready for review. It all works without any breaking changes. The only thing I haven't tested is poetry publish.

@carmenbianca
Copy link
Member Author

poetry publish tested. It works, with two caveats:

  • Signing with GPG keys not possible.
  • Because of our build.py step, the resulting wheel is not 'noarch'. This is incorrect, but I've not found a way to fix it. There probably will be a way to fix this once Poetry starts stabilising and documenting the build plugin system.

@carmenbianca
Copy link
Member Author

carmenbianca commented Oct 17, 2022

TODO: add runtime dependency on setuptools (pkg_resources)

README.md Show resolved Hide resolved
@nicorikken
Copy link
Member

I just tested the poetry install and poetry run reuse ... commands and it works well. For me this simplifies setting up a development environment. Thanks a lot!

Signed-off-by: Carmen Bianca Bakker <[email protected]>
Signed-off-by: Carmen Bianca Bakker <[email protected]>
Signed-off-by: Carmen Bianca Bakker <[email protected]>
@carmenbianca
Copy link
Member Author

carmenbianca commented Nov 1, 2022

Failing py3.11 test because of pytest-dev/pytest-cov#564

Signed-off-by: Carmen Bianca Bakker <[email protected]>
Signed-off-by: Carmen Bianca Bakker <[email protected]>
Signed-off-by: Carmen Bianca Bakker <[email protected]>
Signed-off-by: Carmen Bianca Bakker <[email protected]>
Signed-off-by: Carmen Bianca Bakker <[email protected]>
Signed-off-by: Carmen Bianca Bakker <[email protected]>
Signed-off-by: Carmen Bianca Bakker <[email protected]>
Signed-off-by: Carmen Bianca Bakker <[email protected]>
Signed-off-by: Carmen Bianca Bakker <[email protected]>
@carmenbianca
Copy link
Member Author

I'm going to just merge this. Rebasing this branch frequently is rather time-consuming, and I've tested this thoroughly enough to know that it just works.

@carmenbianca carmenbianca merged commit 2b0d470 into fsfe:main Nov 1, 2022
@linozen
Copy link
Contributor

linozen commented Nov 2, 2022

@carmenbianca Thanks! Sorry for not getting on this earlier.

@carmenbianca
Copy link
Member Author

@linozen No worries! For the longest time, I maintained this project solo. Having more input is truly amazing, but by no means a blocker to keep the ball slowly moving :) Just let me know if I do something truly stupid.

@grawlinson
Copy link
Contributor

This seems to break python -m build on Arch Linux.

@carmenbianca
Copy link
Member Author

@grawlinson 1.1.0 was released yesterday. It changed the build system.

@grawlinson
Copy link
Contributor

The build module is a PEP-517 compatible build backend that invokes the specified PEP-517 build method, and is what we use on Arch instead of the various PEP-517 tools (flit, poetry, etc).

Shall I open an issue?

@carmenbianca
Copy link
Member Author

I see. Strange. Please open an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants