Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support API version >=1.25 for Docker on Windows support #649

Closed
schmichael opened this issue May 10, 2017 · 4 comments
Closed

Support API version >=1.25 for Docker on Windows support #649

schmichael opened this issue May 10, 2017 · 4 comments

Comments

@schmichael
Copy link

schmichael commented May 10, 2017

Docker on Windows adds some complexity over previous Docker releases as it supports two modes of operation: Linux or Windows containers. Images are OS specific. In order to determine if an image will run, two new pieces of metadata are needed:

As we need these API changes for Nomad (and maybe more I haven't discovered yet) I'll try to submit a PR, but we don't have this particular issue prioritized yet.

@fsouza
Copy link
Owner

fsouza commented May 11, 2017

@schmichael I can take a look at this before the weekend, but let me know if you start working on it before :)

@schmichael
Copy link
Author

Thanks! I'll make sure to comment here before starting work, but I doubt it'd be this week anyway.

fsouza added a commit that referenced this issue May 12, 2017
@fsouza fsouza closed this as completed in 6936859 May 12, 2017
@fsouza
Copy link
Owner

fsouza commented May 12, 2017

@schmichael I just pushed the change! :)

@schmichael
Copy link
Author

Looks great! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants