-
Notifications
You must be signed in to change notification settings - Fork 564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support API version >=1.25 for Docker on Windows support #649
Comments
7 tasks
@schmichael I can take a look at this before the weekend, but let me know if you start working on it before :) |
Thanks! I'll make sure to comment here before starting work, but I doubt it'd be this week anyway. |
@schmichael I just pushed the change! :) |
Looks great! Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Docker on Windows adds some complexity over previous Docker releases as it supports two modes of operation: Linux or Windows containers. Images are OS specific. In order to determine if an image will run, two new pieces of metadata are needed:
Image.Os
(fromGET /images/(name)/json
has been around since at least API version 1.23 but is missing from the structDockerInfo.Isolation
was added toGET /info
in API version 1.25 - structhyperv
seems to mean Windows mode, and""
(a blank string) means Linux mode. (This is a bit confusing since Microsoft's documentation lists HyperV and Windows Server Containers as 2 different modes which appear to be distinct from Docker's 2 modes.)As we need these API changes for Nomad (and maybe more I haven't discovered yet) I'll try to submit a PR, but we don't have this particular issue prioritized yet.
The text was updated successfully, but these errors were encountered: