Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support custom Cognito Domains #6

Closed
MauriceBrg opened this issue Mar 31, 2024 · 0 comments
Closed

Support custom Cognito Domains #6

MauriceBrg opened this issue Mar 31, 2024 · 0 comments
Assignees
@MauriceBrg
Labels
enhancement New feature or request

Comments

@MauriceBrg
Copy link
Collaborator

Cognito allows you to make the hosted UI available under a custom domain.

Currently the package only supports domains under the Cognito namespace.

When using a non-Cognito domain, the User Pools region shouldn't be required to build the URLs.
This is currently a mandatory attribute, which can become optional.
It's still required when using a domain from the Cognito namespace.

Changes should be mostly in dash_cognito_auth.cognito.make_cognito_blueprint
@MauriceBrg MauriceBrg added the enhancement New feature or request label Mar 31, 2024
@MauriceBrg MauriceBrg self-assigned this Mar 31, 2024
MauriceBrg added a commit to MauriceBrg/dash-cognito-auth that referenced this issue Apr 1, 2024
@MauriceBrg
Add support for custom domains and clean up fspijkerman#6
e8fc9a2
@MauriceBrg MauriceBrg mentioned this issue Apr 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MauriceBrg MauriceBrg

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

When branches are created from issues, their pull requests are automatically linked.

feat-custom-domain-support MauriceBrg/dash-cognito-auth
1 participant
@MauriceBrg