-
Notifications
You must be signed in to change notification settings - Fork 588
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release notes not parsing the last version #2680
Comments
Welcome to the FAKE community! Thank you so much for creating your first issue and therefore improving the project! |
I ran into this after updating Fake.Core.ReleaseNotes from 5.20.4 to 5.22.0 -- no problem grabbing the first listed version from the release notes file before that update. |
… file because of a bug in Fake.Core.ReleaseNotes that prevents the version from being lowered: fsprojects/FAKE#2680
Thanks for reporting. If you would like more control on which entry to get as latest, you can use let releaseByDate =
ReleaseNotes.load "RELEASE_NOTES.md"
|> List.sortBy (fun x -> x.Date) |
* global.json: Allow any .NET Core 6.x SDK * Changed .NET Framework target from net45 to net461, added target framework folder to NuGet package * Reverted OpenNLP to version 1.9.1 * RELEASE_NOTES.md: Updated to 1.9.1.2-preview0001 * TO REVERT: RELEASE_NOTES.md: Temporarily removed 1.9.3 and 1.9.4 from file because of a bug in Fake.Core.ReleaseNotes that prevents the version from being lowered: fsprojects/FAKE#2680 * Updated IKVM to 8.2.0-prerelease0392 and updated build/tests * .github/workflows/main.yml: Added .NET Core 3.1 SDK * .github/workflows/main.yml: Build on windows-latest, test windows-latest/ubuntu-latest/macOS-latest * Removed dependency on NUnit.ConsoleRunner * feat: update paket and fake, run fake on .net 6 * feat: update IKVM & OpenNLP * fix: typos * fix: nostdlib * feat: update ikvm to release version * fix: ikvmc errors * fix: release notes and dependencies file * feat: dependencies update * fix: revert opennlp to v1.9.4 * fix: simplify build script Co-authored-by: Shad Storhaug <[email protected]>
closing this due to inactivity, please feel free to re-open or open a new issue if anything still needs to be addressed. |
Description
I am attempting to patch an older version (1.9.1.1) and re-release it (1.9.1.2). The release notes have 2 higher version numbers, 1.9.3, and 1.9.4. However, the release notes logic always picks the highest version from the file instead of the one at the top of the file.
I thought it might be related to line endings or something like that, but I have checked and they are all the same.
I haven't found any other solution than to delete version 1.9.3 and 1.9.4 from the file before the build. Is there a way to do this release without destroying the release notes?
Repro steps
Please provide the steps required to reproduce the problem
Expected behavior
The release version will be the one at the top of the file (or at least with the latest date).
Actual behavior
The release version is always the highest version number in the file, even if that is not the version being released.
Known workarounds
Deleting the release notes for the higher releases works, but is a poor solution.
Related information
FAKE 5 - F# Make (5.20.4) (this line is written to standard error, see #2066)
FakePath: F:\Users\shad.nuget\packages\fake-cli\5.20.4\tools\netcoreapp2.1\any\Fake.Runtime.dll
Paket.Core: 5.257.0
The text was updated successfully, but these errors were encountered: