Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added WarnAsError to MSBuild options #1691

Merged
merged 2 commits into from
Oct 22, 2017
Merged

Added WarnAsError to MSBuild options #1691

merged 2 commits into from
Oct 22, 2017

Conversation

seanamos
Copy link

Resolves #1662

Allows you to specify MSBuild error codes to fail the build with:

    { MSBuildDefaults with
        WarnAsError = Some [] }

     = msbuild /warnaserror

    { MSBuildDefaults with
        WarnAsError = Some ["MSB4237"; "MSB4011"] }

    = msbuild /warnaserror:MSB4237;MSB4011

@dungpa
Copy link
Contributor

dungpa commented Oct 20, 2017

@matthid @forki Is this possible to merge this PR and release a new NuGet package version? Thanks.

@matthid matthid merged commit 499d302 into fsprojects:master Oct 22, 2017
@seanamos seanamos deleted the feature/msbuild-warnaserror branch October 23, 2017 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@seanamos @dungpa @matthid