Ported ReportGeneratorHelper to FAKE 5 #1887
Conversation
|
Wow you are on a streak right now :). Thanks! Can you take a look at the documentation around the new modules as well? Stuff needs to move into the correct section in the template and It might very well possible that there are no existing docs then nothing needs to be done ... |
|
I added the documentation for the report generator. I will add the docs for the other PR's as well (but in the other PR's ;) |
| @@ -140,6 +140,7 @@ | |||
| <a href="@(prefix)apidocs/index.html#Fake.Testing">Testing</a> | |||
| <ul> | |||
| <li><a href="@(prefix)testing-sonarqube.html">SonarQube</a></li> | |||
| <li><a href="@(prefix)testing-reportgenerator.html">ReportGenerator</a></li> | |||
There was a problem hiding this comment.
Feel free to just link the API-Reference-documentation. I wasn't after adding a markdown file for each module (inline /// documentation works as well).
I was more after looking for todo- docs in https://github.com/fsharp/FAKE/tree/master/help/markdown but it looks like none of your modules was documented previously.
Anyway thanks so much! :)
| | Error = 2 | ||
|
|
||
| /// ReportGenerator parameters, for more details see: https://github.com/danielpalme/ReportGenerator. | ||
| [<CLIMutable>] |
| let private currentDirectory = Directory.GetCurrentDirectory () | ||
|
|
||
| /// ReportGenerator default parameters | ||
| let ReportGeneratorDefaultParams = |
| let taskName = "ReportGenerator" | ||
| let description = "Generating reports" | ||
|
|
||
| Trace.traceStartTaskUnsafe taskName description |
|
I reviewed all PRs and they look very good, only some smaller things left. I changed the base branch to rc_8 as I'd like to add them to the next release :). |
|
@matthid Fixed |
|
Thanks! |
|
Good job |
Ported ReportGeneratorHelper to FAKE 5 as Fake.Testing.ReportGenerator