Fixed WatchChanges not properly removing subdirectories from watch list #908
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the scenario where
WatchChanges
is used with multiple includes, if one include is a subdirectory of another, WatchChanges will not watch the correct directory.For example:
/parent/child
will be watched (incorrectly), instead of/parent
.This PR fixes this issue and refactors the code a little in order to implement a couple of tests to ensure the correct behaviour when eliminating subdirectories from the watch list.