A new rule that finds used underscore prefixed elements

[webwarrior-ws]

Supersedes #591

Fixes #573

[knocte]

This branch has conflicts that must be resolved

@webwarrior-ws bad rebase ^ ; also, please push 1 by 1

[knocte]

@webwarrior-ws I think what you did wrong here when squashing is overlooking/disregarding this common pitfall about git: https://github.com/nblockchain/conventions/blob/master/docs/WorkflowGuidelines.md?plain=1#L245

[webwarrior-ws]

When I rebased there were no conflicts. Then I was squashing commits and something must have gone wrong there.

[knocte]

and something must have gone wrong there.

Exactly what I meant when I pointed to our documentation, please read this line: https://github.com/nblockchain/conventions/blob/master/docs/WorkflowGuidelines.md?plain=1#L245

[knocte]

@webwarrior-ws shouldn't 06fb857's CI be green instead of red?

[webwarrior-ws]

@webwarrior-ws shouldn't 06fb857's CI be green instead of red?

In this commit I made tests pass, but self-check fails revealing another bug. Then I added test for this case in next commit and fix in the last commit.

[knocte]

I think the first 7 commits need to be squashed, we don't gain anything by having them split in many, and their CI statuses are all red anyway (without having a failing test).

[webwarrior-ws]

Squashed first 7 commits

[knocte]

@webwarrior-ws commits c0559b8 and 886f064 can be squashed properly too. Also don't forget to address last commit (make test pass -> CI green). Thanks

[knocte]

@webwarrior-ws please note: as the quickfix commits (the last three) require more discussion, I've removed them from this PR. So, once I merge it, you can create new PR for those commits (e.g. cherry-picking them from this backup branch where I pushed them: https://github.com/knocte/FSharpLint/commits/addQuickFixToRule82/ ).