Fix bugs in NoPartialFunctions rule #653
Merged
+239
−43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added failing test for NoPartialFunctions for case when `Value` member is called on result of `List.tryHead`.
Fixed NoPartialFunctions rule for case when instance member is called on arbitrary expression, not just dotted identifier.
Added regression test for NoPartialFunctions for case when `Value` instance method is called on non value that is not Option, but another Option value exists in scope.
Fix case when `Value` instance method is called on value that is not Option, but another Option value exists in scope.
webwarrior-ws
force-pushed
the
partial-functions-value-squashed
branch
from
9b2b20a to
b55f5b6
Compare
Use lookup in partialInstanceMemberIdentifiers list instead of pattern matching in getFunctionValTypeName function. This means less places to modify when adding new instance member replacement strategy.
webwarrior-ws
force-pushed
the
partial-functions-value-squashed
branch
from
01b2627 to
eaac788
Compare
knocte
added a commit
to knocte/FSharpLint
that referenced
this pull request
Jan 13, 2024
…value-squashed" This reverts commit fcf9213 temporarily, because it caused a regression in the rule that we caught when trying to rebase PR fsprojects#668 (it crashes FSharpLint when trying to use FSharpLint on itself).
knocte
added a commit
that referenced
this pull request
Jan 15, 2024
…lue-squashed"" This reverts commit b69b24b because now that we have release 0.24.0 (stable version) we can reintroduce this PR again which causes a regression which we will fix in the next upcoming prereleases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix bugs in NoPartialFunctions rule:
Valueinstance method is called on value that is notOption, but anotherOptionvalue exists in scope.Added tests for these cases.