-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New typePrefixing modes "Always" and "Never" (default: "Hybrid") #661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As we're going to change how the configuration of this rule is structured, we first create a test to make sure the old config works.
…ady) The 'Always' mode behaves in the same way for this case.
knocte
changed the title
WIP: New typePrefixing modes "Always" and "Never" (default: "Hybrid)
WIP: New typePrefixing modes "Always" and "Never" (default: "Hybrid")
Dec 30, 2023
Also editing an existing Hybrid mode one to make sure we don't break it.
knocte
force-pushed
the
typePrefixingModes
branch
from
December 30, 2023 11:45
1e486df
to
c6c0488
Compare
Handle case of array types like `foo[]` in Always mode.
Re-enabled regression test for TypePrefixing rule with old config format and made it pass.
knocte
changed the title
WIP: New typePrefixing modes "Always" and "Never" (default: "Hybrid")
New typePrefixing modes "Always" and "Never" (default: "Hybrid")
Jan 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.