Fix recent regression in MaxLinesIn* rules #667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knocte
reviewed
Jan 5, 2024
knocte
reviewed
Jan 5, 2024
Mersho
force-pushed
the
FixMaxLineRules-squashed
branch
7 times, most recently
from
59cef2d to
db0e3e6
Compare
The MaxLinesIn* rules skip blank lines since PR#644 [1], but we forgot to change `generateNewLines()` function to generate NOP lines instead of blank lines. Co-authored-by: webwarrior <[email protected]> [1] fsprojects#644
Fix `blankLinesCount` bug to count the amount of blank lines correctly (regression accidentally introduced in PR#644[1]). [1] fsprojects#644 Co-authored-by: webwarrior <[email protected]>
knocte
force-pushed
the
FixMaxLineRules-squashed
branch
from
c5292c5 to
649389f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #644 accidentally introduced a bug that would render the MaxLinesIn* rules useless.