Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate some functions in Validation #248

Merged
merged 8 commits into from
Jan 24, 2020
Merged

Deprecate some functions in Validation #248

merged 8 commits into from
Jan 24, 2020

Conversation

wallymathieu
Copy link
Member

No description provided.

@wallymathieu wallymathieu requested a review from gusty January 23, 2020 18:31
@gusty gusty changed the title Deprecate validate method since it's less generic than intended [WIP] Deprecate some functions in Validation Jan 23, 2020
@gusty
Copy link
Member

gusty commented Jan 23, 2020

We can also take the opportunity to rename (and deprecate) both orElse and valueOr as they should be aligned with the recent naming (which at the same time is aligned with the existing F# core functions) defaultValue and defaultWith.

@gusty
Copy link
Member

gusty commented Jan 23, 2020

All green. Please Squash and Merge at your convenience.

@wallymathieu
Copy link
Member Author

Thanks @gusty for the help!

@wallymathieu wallymathieu changed the title [WIP] Deprecate some functions in Validation Deprecate some functions in Validation Jan 24, 2020
@wallymathieu wallymathieu merged commit a76958b into fsprojects:master Jan 24, 2020
@gusty gusty mentioned this pull request Nov 18, 2022
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gusty gusty gusty left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wallymathieu @gusty