Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch tests to netcoreapp31 #157

Merged

Conversation

gdziadkiewicz
Copy link
Collaborator

No description provided.

os:
- linux
- osx
dist: xenial # Ubuntu 16
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

]
},
"paket": {
"version": "5.245.1",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't use 5.245.2, because Fake suggests sticking with 5.245.1

nuget Expecto.FsCheck
nuget FsCheck
nuget Expecto.VisualStudio.TestAdapter version_in_path: true
nuget Expecto 8.12
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Versions added to stay on the versions used in the previous version - I didn't want to change the versions.

@@ -19,15 +19,14 @@ source https://api.nuget.org/v3/index.json

storage: none

clitool dotnet-fake
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed this to the dotnet tool manifesto approach as suggested in fsprojects/FAKE#2465

@gdziadkiewicz gdziadkiewicz mentioned this pull request May 30, 2020
@jackfoxy jackfoxy merged commit a78aedd into fsprojects:master May 30, 2020
@gdziadkiewicz gdziadkiewicz deleted the test_on_netcore31_minimal_changes branch May 31, 2020 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants