Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#191: Fix ofCase that now handles 'None'. #192

Merged
merged 4 commits into from
Oct 12, 2021
Merged

#191: Fix ofCase that now handles 'None'. #192

merged 4 commits into from
Oct 12, 2021

Conversation

CaptnCodr
Copy link
Member

As Don mentioned in the issue None is represented as null at runtime.
That fixes the NullReferenceException.

sergey-tihon
sergey-tihon reviewed Oct 12, 2021
View reviewed changes
src/Common.fs Outdated Show resolved Hide resolved
@sergey-tihon
Copy link
Member

@CaptnCodr Everything looks good! Thank for the fix.

@CaptnCodr
Copy link
Member Author

I think this is now better formatted.
I will ship it as v4.0.7.

@CaptnCodr CaptnCodr merged commit b3bdc32 into fsprojects:master Oct 12, 2021
@CaptnCodr CaptnCodr deleted the bugfix/191-ofCase-None branch October 12, 2021 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergey-tihon sergey-tihon sergey-tihon left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CaptnCodr @sergey-tihon